std: clean up ptr a bit #12282
Closed
std: clean up ptr a bit #12282
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| */ | ||
| #[inline(always)] | ||
| pub unsafe fn read_ptr<T>(src: *T) -> T { | ||
| pub unsafe fn read<T>(src: *T) -> T { |
There was a problem hiding this comment.
Is there a reason these can't be methods on RawPtr?
There was a problem hiding this comment.
(Reproduced here)
Changing ptr::read to RawPtr::read is extremely inconvenient because, with ptr::read, &T will be coerced, whereas it will not be when it is a method. This introduces quite unnecessary casts. I do not wish to change it.
|
r=me with the import in the right spot |
bors
added a commit
that referenced
this pull request
Feb 15, 2014
chris-morgan
added a commit
to chris-morgan/ncurses-rs
that referenced
this pull request
Feb 16, 2014
jeaye
pushed a commit
to jeaye/ncurses-rs
that referenced
this pull request
Feb 16, 2014
Remove to_unsafe_ptr usage (rust-lang/rust#12282).
matthiaskrgr
pushed a commit
to matthiaskrgr/rust
that referenced
this pull request
Mar 21, 2024
Handle false positive with `map_clone` lint ### Summary - Fixes rust-lang/rust-clippy#12271 - (This is my first contribution to clippy and any suggestion would be appreciated) changelog: [`map_clone`]: Handle false positive with `map_clone` lint
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.