Treat args/env as lossy UTF-8 #12283
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| pub fn as_bytes_no_nul<'a>(&'a self) -> &'a [u8] { | ||
| if self.buf.is_null() { fail!("CString is null!"); } | ||
| unsafe { | ||
| cast::transmute((self.buf, self.len())) |
There was a problem hiding this comment.
Transmute a raw::Slice to avoid accidentally getting the order mixed up.
There was a problem hiding this comment.
Good idea. I was copying as_bytes() but this is a good excuse to fix that.
os::args() was using str::raw::from_c_str(), which would assert if the C-string wasn't valid UTF-8. Switch to using from_utf8_lossy() instead, and add a separate function os::args_as_bytes() that returns the ~[u8] byte-vectors instead.
Parse the environment by default with from_utf8_lossy. Also provide byte-vector equivalents (e.g. os::env_as_bytes()). Unfortunately, setenv() can't have a byte-vector equivalent because of Windows support, unless we want to define a setenv_bytes() that fails under Windows for non-UTF8 (or non-UTF16).
|
New version pushed |
|
Generally I like this approach. Why |
|
The character |
bors
added a commit
that referenced
this pull request
Feb 15, 2014
Change `os::args()` and `os::env()` to use `str::from_utf8_lossy()`. Add new functions `os::args_as_bytes()` and `os::env_as_bytes()` to retrieve the args/env as byte vectors instead. The existing methods were left returning strings because I expect that the common use-case is to want string handling. Fixes #7188.
flip1995
pushed a commit
to flip1995/rust
that referenced
this pull request
Feb 26, 2024
Minor refactor format-args * Move all linting logic into a single format implementations struct This should help with the future format-args improvements. **NOTE TO REVIEWERS**: use "hide whitespace" in the github diff -- most of the code has shifted, but relatively low number of lines actually modified. Followig up from rust-lang#12274 r? `@xFrednet` --- changelog: none
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change
os::args()andos::env()to usestr::from_utf8_lossy().Add new functions
os::args_as_bytes()andos::env_as_bytes()to retrieve the args/env as byte vectors instead.The existing methods were left returning strings because I expect that the common use-case is to want string handling.
Fixes #7188.