Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove DefId's Partial/Ord impls #122832

Merged
merged 20 commits into from
Mar 28, 2024
Merged

Remove DefId's Partial/Ord impls #122832

merged 20 commits into from
Mar 28, 2024

Commits on Mar 27, 2024

  1. Remove unnecessary Partial/Ord derive

    @oli-obk
    oli-obk committed Mar 27, 2024
    Configuration menu
    Copy the full SHA
    2707ac9 View commit details
    Browse the repository at this point in the history

  2. Use TraitRef::to_string sorting in favor of TraitRef::ord, as the… 

    … latter compares `DefId`s which we need to avoid
    @oli-obk
    oli-obk committed Mar 27, 2024
    Configuration menu
    Copy the full SHA
    ae24fef View commit details
    Browse the repository at this point in the history

  3. Use FxIndexMap instead of BTreeMap to avoid sorting DefIds

    @oli-obk
    oli-obk committed Mar 27, 2024
    Configuration menu
    Copy the full SHA
    5ae546e View commit details
    Browse the repository at this point in the history

  4. Sort diagnostics by rendered trait ref instead of its def ids

    @oli-obk
    oli-obk committed Mar 27, 2024
    Configuration menu
    Copy the full SHA
    939df29 View commit details
    Browse the repository at this point in the history

  5. Remove Ord from Ty, Const, and Region

    @oli-obk
    oli-obk committed Mar 27, 2024
    Configuration menu
    Copy the full SHA
    dc95bd6 View commit details
    Browse the repository at this point in the history

  6. Remove Ord from Binder

    @oli-obk
    oli-obk committed Mar 27, 2024
    Configuration menu
    Copy the full SHA
    dd9fe01 View commit details
    Browse the repository at this point in the history

  7. Remove Ord from BoundTy

    @oli-obk
    oli-obk committed Mar 27, 2024
    Configuration menu
    Copy the full SHA
    e87d108 View commit details
    Browse the repository at this point in the history

  8. Remove Partial/Ord from BoundRegion

    @oli-obk
    oli-obk committed Mar 27, 2024
    Configuration menu
    Copy the full SHA
    459ea32 View commit details
    Browse the repository at this point in the history

  9. Remove Partial/Ord from AdtDef

    @oli-obk
    oli-obk committed Mar 27, 2024
    Configuration menu
    Copy the full SHA
    1d662c9 View commit details
    Browse the repository at this point in the history

  10. Remove Partial/Ord from EarlyParamRegion

    @oli-obk
    oli-obk committed Mar 27, 2024
    Configuration menu
    Copy the full SHA
    28363ea View commit details
    Browse the repository at this point in the history

  11. Do not sort DefIds in diagnostics

    @oli-obk
    oli-obk committed Mar 27, 2024
    Configuration menu
    Copy the full SHA
    150a5e5 View commit details
    Browse the repository at this point in the history

  12. Don't sort DefIds in suggestions

    @oli-obk
    oli-obk committed Mar 27, 2024
    Configuration menu
    Copy the full SHA
    7278072 View commit details
    Browse the repository at this point in the history

  13. Sort method suggestions by DefPath instead of DefId

    @oli-obk
    oli-obk committed Mar 27, 2024
    Configuration menu
    Copy the full SHA
    57f68c3 View commit details
    Browse the repository at this point in the history

  14. Sort a diagnostic by DefPathStr instead of DefId

    @oli-obk
    oli-obk committed Mar 27, 2024
    Configuration menu
    Copy the full SHA
    6be79cb View commit details
    Browse the repository at this point in the history

  15. Sort somem diagnostics by DefPathStr instead of DefId

    @oli-obk
    oli-obk committed Mar 27, 2024
    Configuration menu
    Copy the full SHA
    5676326 View commit details
    Browse the repository at this point in the history

  16. Stop sorting DefIds in the compiler

    @oli-obk
    oli-obk committed Mar 27, 2024
    Configuration menu
    Copy the full SHA
    e522d29 View commit details
    Browse the repository at this point in the history

  17. Remove DefId's Partial/Ord impls

    @oli-obk
    oli-obk committed Mar 27, 2024
    Configuration menu
    Copy the full SHA
    5f4ac61 View commit details
    Browse the repository at this point in the history

  18. Ensure no one re-adds Partial/Ord impls for DefId

    @oli-obk
    oli-obk committed Mar 27, 2024
    Configuration menu
    Copy the full SHA
    cf3ab41 View commit details
    Browse the repository at this point in the history

  19. Add rustdoc hack

    @oli-obk
    oli-obk committed Mar 27, 2024
    Configuration menu
    Copy the full SHA
    d03df0a View commit details
    Browse the repository at this point in the history

  20. Int constants must be valtrees in pattern lowering

    @oli-obk
    oli-obk committed Mar 27, 2024
    Configuration menu
    Copy the full SHA
    bd6a96f View commit details
    Browse the repository at this point in the history