-
Notifications
You must be signed in to change notification settings - Fork 12.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Move --sysroot
argument out of the argument file to fix miri issue
#123030
Move --sysroot
argument out of the argument file to fix miri issue
#123030
Conversation
ac9b4e6
to
8c219af
Compare
Thanks a lot! Yes I hope this will resolve the Miri issue. |
@bors r+ |
@bors p=1 |
☀️ Test successful - checks-actions |
Finished benchmarking commit (cb7c636): comparison URL. Overall result: no relevant changes - no action needed@rustbot label: -perf-regression Instruction countThis benchmark run did not return any relevant results for this metric. Max RSS (memory usage)ResultsThis is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.
CyclesResultsThis is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.
Binary sizeThis benchmark run did not return any relevant results for this metric. Bootstrap: 672.431s -> 670.74s (-0.25%) |
Fixes rust-lang/miri#3404.
For now, miri needs this argument to be moved out of the arg file so they can update it if needed.
cc @RalfJung
r? @notriddle