Remove check-fast. Closes #4193, #8844, #6330, #7416 #12304
Conversation
|
Out of interest, how long does the full test suite take to run on windows? (Also, needs a rebase.) |
|
I, too, am curious about how this would affect cycle time. We definitely don't want cycle time to go up, so I think we should see how long the suite is on windows before merging. |
|
I can run a test. |
|
On win1 before removal check-fast took 16m; after, check-lite takes 24m. |
|
That doesn't sound nearly as bad as I thought it was, but it also may push the windows bots to being the slowest bots. I think that the linux bots would be faster by 10-20min at that point. That doesn't sound too bad, and we could always slim down slower portions of the windows test suite if necessary. |
|
It sounds like we could largely speed-up Windows according to #8844 (comment). |
|
If check-lite is not fast enough we can change it to test fewer things. |
|
For the compile-fail test, is it possible to do If so, r=me |
This fixes struct passing abi on x86 ffi: Structs are now passed indirectly with byval attribute (as clang does).
Broken on BSD. rust-lang#12460
This should make BSD use the proper GNU make.
|
Closing in favor of #13288 |
…ents, r=jonas-schievink minor: Include self type in generated getter/setter docs
No description provided.