Enable `CrateNum` query feeding via `TyCtxt` #123126

oli-obk · 2024-03-27T08:12:02Z

Instead of having a magic function that violates some TyCtxtFeed invariants, add a create_def equivalent for CrateNums.

Note that this still isn't tracked by the query system (unlike create_def), and that feeding most CrateNum queries for crates other than the local one will likely cause performance regressions.

These things should be attempted on their own separately, but this PR should stand on its own

rustbot · 2024-03-27T08:12:10Z

r? @davidtwco

rustbot has assigned @davidtwco.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

oli-obk · 2024-03-27T08:12:11Z

@bors try @rust-timer queue

Enable `CrateNum` query feeding via `TyCtxt` Instead of having a magic function that violates some `TyCtxtFeed` invariants, add a `create_def` equivalent for `CrateNum`s. Note that this still isn't tracked by the query system (unlike `create_def`), and that feeding most `CrateNum` queries for crates other than the local one will likely cause performance regressions. These things should be attempted on their own separately, but this PR should stand on its own

bors · 2024-03-27T08:13:21Z

⌛ Trying commit 36c0890 with merge 6244bac...

bors · 2024-03-27T09:44:22Z

☀️ Try build successful - checks-actions
Build commit: 6244bac (6244bacfe63a742193b8045731b144919700baae)

bors · 2024-03-27T09:44:22Z

☀️ Try build successful - checks-actions
Build commit: 6244bac (6244bacfe63a742193b8045731b144919700baae)

rust-timer · 2024-03-27T19:12:49Z

Finished benchmarking commit (6244bac): comparison URL.

Overall result: ❌ regressions - ACTION NEEDED

Benchmarking this pull request likely means that it is perf-sensitive, so we're automatically marking it as not fit for rolling up. While you can manually mark this PR as fit for rollup, we strongly recommend not doing so since this PR may lead to changes in compiler perf.

Next Steps: If you can justify the regressions found in this try perf run, please indicate this with @rustbot label: +perf-regression-triaged along with sufficient written justification. If you cannot justify the regressions please fix the regressions and do another perf run. If the next run shows neutral or positive results, the label will be automatically removed.

@bors rollup=never
@rustbot label: -S-waiting-on-perf +perf-regression

Instruction count

This is a highly reliable metric that was used to determine the overall result at the top of this comment.

	mean	range	count
Regressions ❌ (primary)	0.3%	[0.1%, 0.5%]	19
Regressions ❌ (secondary)	0.4%	[0.2%, 0.6%]	10
Improvements ✅ (primary)	-	-	0
Improvements ✅ (secondary)	-	-	0
All ❌✅ (primary)	0.3%	[0.1%, 0.5%]	19

Max RSS (memory usage)

Results

This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.

	mean	range	count
Regressions ❌ (primary)	-	-	0
Regressions ❌ (secondary)	-	-	0
Improvements ✅ (primary)	-1.9%	[-5.0%, -0.6%]	13
Improvements ✅ (secondary)	-3.1%	[-5.7%, -1.9%]	32
All ❌✅ (primary)	-1.9%	[-5.0%, -0.6%]	13

Cycles

Results

This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.

	mean	range	count
Regressions ❌ (primary)	0.7%	[0.6%, 0.8%]	4
Regressions ❌ (secondary)	4.8%	[4.8%, 4.8%]	1
Improvements ✅ (primary)	-	-	0
Improvements ✅ (secondary)	-	-	0
All ❌✅ (primary)	0.7%	[0.6%, 0.8%]	4

Binary size

This benchmark run did not return any relevant results for this metric.

Bootstrap: 669.488s -> 670.641s (0.17%)
Artifact size: 315.76 MiB -> 315.72 MiB (-0.01%)

oli-obk · 2024-03-28T11:07:56Z

it looks like there are extra executions of incr_comp_encode_dep_graph, but I can't tell how that happens ☹️

davidtwco · 2024-04-02T10:20:27Z

r=me unless you want to investigate this.

This way it's like `Definitions`, which creates `DefId`s by interning `DefPathData`s, but for interning stable crate hashes

…Ctxt`

oli-obk · 2024-04-19T14:24:03Z

@bors try @rust-timer queue

bors · 2024-04-19T14:25:13Z

⌛ Trying commit e9a2f8f with merge 73c144d...

Enable `CrateNum` query feeding via `TyCtxt` Instead of having a magic function that violates some `TyCtxtFeed` invariants, add a `create_def` equivalent for `CrateNum`s. Note that this still isn't tracked by the query system (unlike `create_def`), and that feeding most `CrateNum` queries for crates other than the local one will likely cause performance regressions. These things should be attempted on their own separately, but this PR should stand on its own

bors · 2024-04-19T15:57:43Z

☀️ Try build successful - checks-actions
Build commit: 73c144d (73c144da054a01b634f764a9a60fb9e619a2cb14)

rust-timer · 2024-04-19T17:40:41Z

Finished benchmarking commit (73c144d): comparison URL.

Overall result: ❌ regressions - ACTION NEEDED

Benchmarking this pull request likely means that it is perf-sensitive, so we're automatically marking it as not fit for rolling up. While you can manually mark this PR as fit for rollup, we strongly recommend not doing so since this PR may lead to changes in compiler perf.

Next Steps: If you can justify the regressions found in this try perf run, please indicate this with @rustbot label: +perf-regression-triaged along with sufficient written justification. If you cannot justify the regressions please fix the regressions and do another perf run. If the next run shows neutral or positive results, the label will be automatically removed.

@bors rollup=never
@rustbot label: -S-waiting-on-perf +perf-regression

Instruction count

This is a highly reliable metric that was used to determine the overall result at the top of this comment.

	mean	range	count
Regressions ❌ (primary)	0.3%	[0.2%, 0.6%]	16
Regressions ❌ (secondary)	0.3%	[0.3%, 0.3%]	3
Improvements ✅ (primary)	-	-	0
Improvements ✅ (secondary)	-	-	0
All ❌✅ (primary)	0.3%	[0.2%, 0.6%]	16

Max RSS (memory usage)

This benchmark run did not return any relevant results for this metric.

Cycles

Results

This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.

	mean	range	count
Regressions ❌ (primary)	-	-	0
Regressions ❌ (secondary)	2.1%	[2.1%, 2.1%]	1
Improvements ✅ (primary)	-	-	0
Improvements ✅ (secondary)	-	-	0
All ❌✅ (primary)	-	-	0

Binary size

This benchmark run did not return any relevant results for this metric.

Bootstrap: 672.208s -> 672.202s (-0.00%)
Artifact size: 315.30 MiB -> 315.27 MiB (-0.01%)

oli-obk · 2024-04-23T14:08:35Z

I did some cachegrind runs, and it looks like a lot of inliner noise with some occasional extra DefId reads from cache. Afaict my code does not change how we interact with the cache, I went over it a few times and don't see anything.

@bors r=davidtwco

bors · 2024-04-23T14:08:38Z

📌 Commit e9a2f8f has been approved by davidtwco

It is now in the queue for this repository.

bors · 2024-04-23T20:46:51Z

⌛ Testing commit e9a2f8f with merge 244da22...

bors · 2024-04-23T22:49:54Z

☀️ Test successful - checks-actions
Approved by: davidtwco
Pushing 244da22 to master...

rust-timer · 2024-04-24T01:04:07Z

Finished benchmarking commit (244da22): comparison URL.

Overall result: ❌✅ regressions and improvements - ACTION NEEDED

Next Steps: If you can justify the regressions found in this perf run, please indicate this with @rustbot label: +perf-regression-triaged along with sufficient written justification. If you cannot justify the regressions please open an issue or create a new PR that fixes the regressions, add a comment linking to the newly created issue or PR, and then add the perf-regression-triaged label to this PR.

@rustbot label: +perf-regression
cc @rust-lang/wg-compiler-performance

Instruction count

This is a highly reliable metric that was used to determine the overall result at the top of this comment.

	mean	range	count
Regressions ❌ (primary)	0.3%	[0.2%, 0.6%]	19
Regressions ❌ (secondary)	0.4%	[0.3%, 0.5%]	5
Improvements ✅ (primary)	-	-	0
Improvements ✅ (secondary)	-0.7%	[-0.7%, -0.7%]	2
All ❌✅ (primary)	0.3%	[0.2%, 0.6%]	19

Max RSS (memory usage)

Results

This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.

	mean	range	count
Regressions ❌ (primary)	1.9%	[1.3%, 2.6%]	2
Regressions ❌ (secondary)	-	-	0
Improvements ✅ (primary)	-	-	0
Improvements ✅ (secondary)	-	-	0
All ❌✅ (primary)	1.9%	[1.3%, 2.6%]	2

Cycles

Results

This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.

	mean	range	count
Regressions ❌ (primary)	-	-	0
Regressions ❌ (secondary)	-	-	0
Improvements ✅ (primary)	-	-	0
Improvements ✅ (secondary)	-2.2%	[-2.2%, -2.2%]	1
All ❌✅ (primary)	-	-	0

Binary size

This benchmark run did not return any relevant results for this metric.

Bootstrap: 674.241s -> 674.182s (-0.01%)
Artifact size: 316.22 MiB -> 316.23 MiB (0.00%)

oli-obk · 2024-04-24T07:38:38Z

@rustbot label: +perf-regression-triaged

#123126 (comment)

rustbot assigned davidtwco Mar 27, 2024

rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. labels Mar 27, 2024

This comment has been minimized.

Sign in to view

rustbot added the S-waiting-on-perf Status: Waiting on a perf run to be completed. label Mar 27, 2024

This comment has been minimized.

Sign in to view

rustbot added perf-regression Performance regression. and removed S-waiting-on-perf Status: Waiting on a perf run to be completed. labels Mar 27, 2024

davidtwco approved these changes Apr 2, 2024

View reviewed changes

oli-obk added 5 commits April 19, 2024 14:09

Create new CrateNum only after knowing it's going to succeed

10be745

Move stable_crate_ids from CrateStore to Untracked

fbc9b94

This way it's like `Definitions`, which creates `DefId`s by interning `DefPathData`s, but for interning stable crate hashes

Isolate CrateNum creation to TyCtxt methods

0025c9c

Prepare for CrateNum query feeding on creation

9e63e99

Remove feed_local_crate in favor of creating the CrateNum via `Ty…

e9a2f8f

…Ctxt`

oli-obk force-pushed the feed_crate_num branch from 36c0890 to e9a2f8f Compare April 19, 2024 14:23

This comment has been minimized.

Sign in to view

rustbot added the S-waiting-on-perf Status: Waiting on a perf run to be completed. label Apr 19, 2024

This comment has been minimized.

Sign in to view

rustbot removed the S-waiting-on-perf Status: Waiting on a perf run to be completed. label Apr 19, 2024

bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Apr 23, 2024

bors added the merged-by-bors This PR was explicitly merged by bors. label Apr 23, 2024

bors merged commit 244da22 into rust-lang:master Apr 23, 2024

rustbot added this to the 1.79.0 milestone Apr 23, 2024

oli-obk deleted the feed_crate_num branch April 24, 2024 07:38

rustbot added the perf-regression-triaged The performance regression has been triaged. label Apr 24, 2024

Enable CrateNum query feeding via TyCtxt #123126

Enable CrateNum query feeding via TyCtxt #123126

Uh oh!

Conversation

oli-obk commented Mar 27, 2024

Uh oh!

rustbot commented Mar 27, 2024

Uh oh!

oli-obk commented Mar 27, 2024

Uh oh!

This comment has been minimized.

bors commented Mar 27, 2024

Uh oh!

bors commented Mar 27, 2024

Uh oh!

bors commented Mar 27, 2024

Uh oh!

This comment has been minimized.

rust-timer commented Mar 27, 2024

Overall result: ❌ regressions - ACTION NEEDED

Uh oh!

oli-obk commented Mar 28, 2024

Uh oh!

davidtwco commented Apr 2, 2024

Uh oh!

oli-obk commented Apr 19, 2024

Uh oh!

This comment has been minimized.

bors commented Apr 19, 2024

Uh oh!

bors commented Apr 19, 2024

Uh oh!

This comment has been minimized.

rust-timer commented Apr 19, 2024

Overall result: ❌ regressions - ACTION NEEDED

Uh oh!

oli-obk commented Apr 23, 2024

Uh oh!

bors commented Apr 23, 2024

Uh oh!

bors commented Apr 23, 2024

Uh oh!

bors commented Apr 23, 2024

Uh oh!

rust-timer commented Apr 24, 2024

Overall result: ❌✅ regressions and improvements - ACTION NEEDED

Uh oh!

oli-obk commented Apr 24, 2024

Uh oh!

Uh oh!

Enable `CrateNum` query feeding via `TyCtxt` #123126

Enable `CrateNum` query feeding via `TyCtxt` #123126