Implement Show for 1-12 element tuples and improve the std::tuple API #12313
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| new_branch = new_outcome.clone().n0(); | ||
| outcome = new_outcome.n1(); | ||
| new_branch = new_outcome.get_0().clone(); | ||
| outcome = new_outcome.get_1().clone(); |
There was a problem hiding this comment.
You're adding extra clones here (not that it matters much given how many clones are in this file), it should really be
let (next_branch, next_outcome) = self.clone().rightmost_child.insert(...);
new_branch = next_branch;
outcome = next_outcome;to avoid the clones. (And below too)
|
Less clutter in the prelude! Yay! |
| fn $mutN<'a>(&'a mut self) -> &'a mut $T { | ||
| // Do this because the macro invocation would exceed | ||
| // the 100 character limit if it also required a | ||
| // $mut_pattern:pat |
There was a problem hiding this comment.
Seriously? You'll use unsafe code and violate some (possible) type invariants for a formatting issue?
Renames the `n*` and `n*_ref` tuple getters to `val*` and `ref*` respectively, and adds `mut*` getters.
These are adequately covered by the Tuple2 trait.
| (n0, n0_ref) -> A { (a,_), (ref a,_) => a } | ||
| (n1, n1_ref) -> B { (_,b), (_,ref b) => b } | ||
| Tuple2 { | ||
| (val0, ref0, mut0) -> A { (a, b) => a } |
There was a problem hiding this comment.
I wonder if it's possible to move the (a, b, ...) bit of the macro expansion to near the Tuple<N> to only need to write it once for each tuple size.
There was a problem hiding this comment.
Hmm, I tried this but I was getting complaints about the expansion depth.
|
Bors didn't seem picking up the r+, so I'm trying a 'r=huonw'. |
bors
added a commit
that referenced
this pull request
Feb 16, 2014
This renames the `n*` and `n*_ref` tuple getters to `val*` and `ref*` respectively, and adds `mut*` getters. It also removes the `CloneableTuple` and `ImmutableTuple` traits.
|
awesome, Thanks! |
bors
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Jul 25, 2022
Removed duplicate 'to' in `cachePriming.numThreads` option description One 'to' too many!
flip1995
pushed a commit
to flip1995/rust
that referenced
this pull request
Feb 26, 2024
Upgrade anstream to 0.6.0 *Please write a short comment explaining your change (or "none" for internal only changes)* changelog: none
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This renames the
n*andn*_reftuple getters toval*andref*respectively, and addsmut*getters. It also removes theCloneableTupleandImmutableTupletraits.