Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[beta] backports #123172

Merged
merged 5 commits into from
Mar 29, 2024
Merged

[beta] backports #123172

merged 5 commits into from
Mar 29, 2024

Commits on Mar 28, 2024

  1. do not eat nested exprs result in format args visitor

    (cherry picked from commit 8beec62)
    lqd authored and cuviper committed Mar 28, 2024
    Configuration menu
    Copy the full SHA
    4cfc174 View commit details
    Browse the repository at this point in the history
  2. add non-regression test for issue 122674

    (cherry picked from commit f3e9dfa)
    lqd authored and cuviper committed Mar 28, 2024
    Configuration menu
    Copy the full SHA
    3b51017 View commit details
    Browse the repository at this point in the history
  3. Fix heading anchors in doc pages.

    (cherry picked from commit 39f2d25)
    ehuss authored and cuviper committed Mar 28, 2024
    Configuration menu
    Copy the full SHA
    44230e4 View commit details
    Browse the repository at this point in the history
  4. Make #[diagnostic::on_unimplemented] format string parsing more robust

    This commit fixes several issues with the format string parsing of the
    `#[diagnostic::on_unimplemented]` attribute that were pointed out by
    @ehuss.
    In detail it fixes:
    
    * Appearing format specifiers (display, etc). For these we generate a
    warning that the specifier is unsupported. Otherwise we ignore them
    * Positional arguments. For these we generate a warning that positional
    arguments are unsupported in that location and replace them with the
    format string equivalent (so `{}` or `{n}` where n is the index of the
    positional argument)
    * Broken format strings with enclosed }. For these we generate a warning
    about the broken format string and set the emitted message literally to
    the provided unformatted string
    * Unknown format specifiers. For these we generate an additional warning
    about the unknown specifier. Otherwise we emit the literal string as
    message.
    
    This essentially makes those strings behave like `format!` with the
    minor difference that we do not generate hard errors but only warnings.
    After that we continue trying to do something unsuprising (mostly either
    ignoring the broken parts or falling back to just giving back the
    literal string as provided).
    
    Fix rust-lang#122391
    
    (cherry picked from commit 5568c56)
    weiznich authored and cuviper committed Mar 28, 2024
    Configuration menu
    Copy the full SHA
    052be5c View commit details
    Browse the repository at this point in the history

Commits on Mar 29, 2024

  1. Update ninja on Windows

    Errors started showing up, and I read somewhere that this might be
    because of old ninja versions. This ninja version is indeed *ancient*.
    
    ```
    multiple outputs aren't (yet?) supported by depslog; bring this up on the mailing list if it affects you
    ```
    
    (cherry picked from commit b546764)
    Noratrieb authored and cuviper committed Mar 29, 2024
    Configuration menu
    Copy the full SHA
    10e6ec5 View commit details
    Browse the repository at this point in the history