-
Notifications
You must be signed in to change notification settings - Fork 13.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add add/sub methods that only panic with debug assertions to rustc #123175
Conversation
r? @wesleywiser rustbot has assigned @wesleywiser. Use |
@wesleywiser o/ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
r=me
Could you fix the PR description as well? I don't think #724 is right 😄
@bors rollup=never Perf sensitive |
This mitigates the perf impact of enabling overflow checks on rustc. The change to use overflow checks will be done in a later PR.
21951cd
to
5039160
Compare
I don't think this should be performance sensitive, but you never know what happens |
☀️ Test successful - checks-actions |
Finished benchmarking commit (af6a161): comparison URL. Overall result: no relevant changes - no action needed@rustbot label: -perf-regression Instruction countThis benchmark run did not return any relevant results for this metric. Max RSS (memory usage)ResultsThis is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.
CyclesResultsThis is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.
Binary sizeThis benchmark run did not return any relevant results for this metric. Bootstrap: 677.445s -> 676.973s (-0.07%) |
This mitigates the perf impact of enabling overflow checks on rustc. The change to use overflow checks will be done in a later PR.
For rust-lang/compiler-team#724, based on data gathered in #119440.