Avoid expanding to unstable internal method #123182
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jhpratt
added
A-macros
rustbot
added
the
S-waiting-on-review
This comment has been minimized.
This comment has been minimized.
rust-cloud-vms
bot
force-pushed
the
fix-decodable-derive
branch
from
5c16969 to
b868352
Compare
This comment has been minimized.
This comment has been minimized.
rust-cloud-vms
bot
force-pushed
the
fix-decodable-derive
branch
from
b868352 to
1fea900
Compare
davidtwco
reviewed
Apr 2, 2024
This comment was marked as duplicate.
This comment was marked as duplicate.
Sorry, something went wrong.
rust-cloud-vms
bot
force-pushed
the
fix-decodable-derive
branch
from
1fea900 to
0fcdf34
Compare
|
@bors r=davidtwco |
bors
added
S-waiting-on-bors
bors
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Apr 3, 2024
Rollup of 5 pull requests Successful merges: - rust-lang#122865 (Split hir ty lowerer's error reporting code in check functions to mod errors.) - rust-lang#122935 (rename ptr::from_exposed_addr -> ptr::with_exposed_provenance) - rust-lang#123182 (Avoid expanding to unstable internal method) - rust-lang#123203 (Add `Context::ext`) - rust-lang#123380 (Improve bootstrap comments) r? `@ghost` `@rustbot` modify labels: rollup
rust-timer
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Apr 3, 2024
Rollup merge of rust-lang#123182 - jhpratt:fix-decodable-derive, r=davidtwco Avoid expanding to unstable internal method Fixes rust-lang#123156 Rather than expanding to `std::rt::begin_panic`, the expansion is now to `unreachable!()`. The resulting behavior is identical. A test that previously triggered the same error as rust-lang#123156 has been added to ensure it does not regress. r? compiler
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #123156
Rather than expanding to
std::rt::begin_panic, the expansion is now tounreachable!(). The resulting behavior is identical. A test that previously triggered the same error as #123156 has been added to ensure it does not regress.r? compiler