-
Notifications
You must be signed in to change notification settings - Fork 12.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[blocked on design] [PoC]: rustdoc (html): add support for variances #123220
Draft
fmease
wants to merge
5
commits into
rust-lang:master
Choose a base branch
from
fmease:rustdoc-variances-html
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+337
−199
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In anticipation of adding variance to them.
rustbot
added
A-rustdoc-json
Area: Rustdoc JSON backend
S-waiting-on-review
Status: Awaiting review from the assignee but also interested parties.
T-rustdoc
Relevant to the rustdoc team, which will review and decide on the PR/issue.
labels
Mar 30, 2024
fmease
added
S-waiting-on-team
Status: Awaiting decision from the relevant subteam (see the T-<team> label).
S-blocked
Status: Blocked on something else such as an RFC or other implementation work.
needs-fcp
This change is insta-stable, so needs a completed FCP to proceed.
and removed
S-waiting-on-review
Status: Awaiting review from the assignee but also interested parties.
labels
Mar 30, 2024
Preemptively locking this. Design discussions should happen over here on Zulip or over at the issue, #22108. |
The job Click to see the possible cause of the failure (guessed by this bot)
|
☔ The latest upstream changes (presumably #123340) made this pull request unmergeable. Please resolve the merge conflicts. |
Dylan-DPC
removed
the
S-waiting-on-team
Status: Awaiting decision from the relevant subteam (see the T-<team> label).
label
May 5, 2024
Dylan-DPC
added
the
S-tracking-design-concerns
Status: There are blocking design concerns.
label
Oct 15, 2024
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Labels
A-rustdoc-json
Area: Rustdoc JSON backend
needs-fcp
This change is insta-stable, so needs a completed FCP to proceed.
S-blocked
Status: Blocked on something else such as an RFC or other implementation work.
S-tracking-design-concerns
Status: There are blocking design concerns.
T-rustdoc
Relevant to the rustdoc team, which will review and decide on the PR/issue.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Sits atop #123219. Together with it this fixes #22108.
r? ghost