Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[blocked on design] [PoC]: rustdoc (html): add support for variances #123220

Draft
wants to merge 5 commits into
base: master
Choose a base branch
from

Conversation

fmease
Copy link
Member

@fmease fmease commented Mar 30, 2024

Sits atop #123219. Together with it this fixes #22108.

r? ghost

@rustbot rustbot added A-rustdoc-json Area: Rustdoc JSON backend S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-rustdoc Relevant to the rustdoc team, which will review and decide on the PR/issue. labels Mar 30, 2024
@fmease fmease added S-waiting-on-team Status: Awaiting decision from the relevant subteam (see the T-<team> label). S-blocked Status: Blocked on something else such as an RFC or other implementation work. needs-fcp This change is insta-stable, so needs a completed FCP to proceed. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Mar 30, 2024
@fmease
Copy link
Member Author

fmease commented Mar 30, 2024

Preemptively locking this. Design discussions should happen over here on Zulip or over at the issue, #22108.

@rust-lang rust-lang locked and limited conversation to collaborators Mar 30, 2024
@rust-log-analyzer
Copy link
Collaborator

The job x86_64-gnu-llvm-17 failed! Check out the build log: (web) (plain)

Click to see the possible cause of the failure (guessed by this bot)
#16 exporting to docker image format
#16 sending tarball 29.1s done
#16 DONE 32.6s
##[endgroup]
Setting extra environment values for docker:  --env ENABLE_GCC_CODEGEN=1 --env GCC_EXEC_PREFIX=/usr/lib/gcc/
[CI_JOB_NAME=x86_64-gnu-llvm-17]
---
sccache: Starting the server...
##[group]Configure the build
configure: processing command line
configure: 
configure: build.configure-args := ['--build=x86_64-unknown-linux-gnu', '--llvm-root=/usr/lib/llvm-17', '--enable-llvm-link-shared', '--set', 'rust.thin-lto-import-instr-limit=10', '--set', 'change-id=99999999', '--enable-verbose-configure', '--enable-sccache', '--disable-manage-submodules', '--enable-locked-deps', '--enable-cargo-native-static', '--set', 'rust.codegen-units-std=1', '--set', 'dist.compression-profile=balanced', '--dist-compression-formats=xz', '--disable-dist-src', '--release-channel=nightly', '--enable-debug-assertions', '--enable-overflow-checks', '--enable-llvm-assertions', '--set', 'rust.verify-llvm-ir', '--set', 'rust.codegen-backends=llvm,cranelift,gcc', '--set', 'llvm.static-libstdcpp', '--enable-new-symbol-mangling']
configure: target.x86_64-unknown-linux-gnu.llvm-config := /usr/lib/llvm-17/bin/llvm-config
configure: llvm.link-shared     := True
configure: rust.thin-lto-import-instr-limit := 10
configure: change-id            := 99999999
---
  Downloaded boml v0.3.1
   Compiling boml v0.3.1
   Compiling y v0.1.0 (/checkout/compiler/rustc_codegen_gcc/build_system)
    Finished `release` profile [optimized] target(s) in 3.46s
     Running `/checkout/obj/build/x86_64-unknown-linux-gnu/stage1-codegen/x86_64-unknown-linux-gnu/release/y test --use-system-gcc --use-backend gcc --out-dir /checkout/obj/build/x86_64-unknown-linux-gnu/stage1-tools/cg_gcc --release --mini-tests --std-tests`
Using system GCC
[BUILD] example
[AOT] mini_core_hello_world
/checkout/obj/build/x86_64-unknown-linux-gnu/stage1-tools/cg_gcc/mini_core_hello_world
abc
---
---- [rustdoc] tests/rustdoc/array-links.rs stdout ----

error: htmldocck failed!
status: exit status: 1
command: "/usr/bin/python3" "/checkout/src/etc/htmldocck.py" "/checkout/obj/build/x86_64-unknown-linux-gnu/test/rustdoc/array-links" "/checkout/tests/rustdoc/array-links.rs"
--- expected ---


<code>pub fn beta&lt;T&gt;() -&gt; &amp;'static <a class="primitive" href="https://doc.rust-lang.org/nightly/core/primitive.array.html">[T; 1]</a></code>

--- actual ---

Build completed unsuccessfully in 0:18:04
Build completed unsuccessfully in 0:18:04
<code>pub fn beta&lt;<sub class="variance">+</sub>T&gt;() -&gt; &amp;'static <a class="primitive" href="https://doc.rust-lang.org/nightly/core/primitive.array.html">[T; 1]</a></code>
--- expected ---


<code>pub fn delta&lt;T&gt;() -&gt; <a class="struct" href="struct.MyBox.html" title="struct foo::MyBox">MyBox</a>&lt;<a class="primitive" href="https://doc.rust-lang.org/nightly/core/primitive.array.html">[T; 1]</a>&gt;</code>

--- actual ---


<code>pub fn delta&lt;<sub class="variance">+</sub>T&gt;() -&gt; <a class="struct" href="struct.MyBox.html" title="struct foo::MyBox">MyBox</a>&lt;<a class="primitive" href="https://doc.rust-lang.org/nightly/core/primitive.array.html">[T; 1]</a>&gt;</code>
--- stderr -------------------------------
--- stderr -------------------------------
text: 'pub fn beta<' != "pub fn beta<T>() -> &'static "
children 1 do not match: code
13: @snapshot check failed
 Actual snapshot value is different than expected
 // @snapshot link_slice_generic - '//pre[@class="rust item-decl"]/code'
text: 'pub fn delta<' != 'pub fn delta<T>() -> '
children 1 do not match: code
25: @snapshot check failed
 Actual snapshot value is different than expected
 // @snapshot link_box_generic - '//pre[@class="rust item-decl"]/code'
Encountered 2 errors
------------------------------------------



---- [rustdoc] tests/rustdoc/async-fn.rs stdout ----

error: htmldocck failed!
status: exit status: 1
command: "/usr/bin/python3" "/checkout/src/etc/htmldocck.py" "/checkout/obj/build/x86_64-unknown-linux-gnu/test/rustdoc/async-fn" "/checkout/tests/rustdoc/async-fn.rs"
--- stderr -------------------------------
12: @has check failed
12: @has check failed
 `XPATH PATTERN` did not match
 // @has async_fn/fn.baz.html '//pre[@class="rust item-decl"]' 'pub async fn baz<T>(a: T) -> T'
87: @has check failed
 `XPATH PATTERN` did not match
     // @has - '//*[@class="method"]' "pub async fn readable<T>(&self) -> Result<AsyncFdReadyGuard<'_, T>, ()>"
95: @has check failed
 `XPATH PATTERN` did not match
 // @has - '//pre[@class="rust item-decl"]' "pub async fn named<'a, 'b>(foo: &'a str) -> &'b str"
98: @has check failed
 `XPATH PATTERN` did not match
 // @has - '//pre[@class="rust item-decl"]' "pub async fn named_trait<'a, 'b>(foo: impl Pattern<'a>) -> impl Pattern<'b>"
Encountered 4 errors
------------------------------------------



---- [rustdoc] tests/rustdoc/auto-trait-bounds-inference-variables-54705.rs stdout ----

error: htmldocck failed!
status: exit status: 1
command: "/usr/bin/python3" "/checkout/src/etc/htmldocck.py" "/checkout/obj/build/x86_64-unknown-linux-gnu/test/rustdoc/auto-trait-bounds-inference-variables-54705" "/checkout/tests/rustdoc/auto-trait-bounds-inference-variables-54705.rs"
--- stderr -------------------------------
7: @has check failed
7: @has check failed
 `XPATH PATTERN` did not match
 // @has - '//*[@id="synthetic-implementations-list"]//*[@class="impl"]//h3[@class="code-header"]' "impl<'scope, S> Send for ScopeFutureContents<'scope, S>where S: Sync"
10: @has check failed
 `XPATH PATTERN` did not match
 // @has - '//*[@id="synthetic-implementations-list"]//*[@class="impl"]//h3[@class="code-header"]' "impl<'scope, S> Sync for ScopeFutureContents<'scope, S>where S: Sync"
Encountered 2 errors
------------------------------------------



---- [rustdoc] tests/rustdoc/auto-trait-negative-impl-55321.rs stdout ----

error: htmldocck failed!
status: exit status: 1
command: "/usr/bin/python3" "/checkout/src/etc/htmldocck.py" "/checkout/obj/build/x86_64-unknown-linux-gnu/test/rustdoc/auto-trait-negative-impl-55321" "/checkout/tests/rustdoc/auto-trait-negative-impl-55321.rs"
--- stderr -------------------------------
17: @has check failed
17: @has check failed
 `XPATH PATTERN` did not match
 // @has - '//*[@id="synthetic-implementations-list"]//*[@class="impl"]//h3[@class="code-header"]' "impl<T> !Send for B<T>"
19: @has check failed
 `XPATH PATTERN` did not match
 // @has - '//*[@id="synthetic-implementations-list"]//*[@class="impl"]//h3[@class="code-header"]' "impl<T> !Sync for B<T>"
Encountered 2 errors
------------------------------------------



---- [rustdoc] tests/rustdoc/auto-trait-bounds-where-51236.rs stdout ----

error: htmldocck failed!
status: exit status: 1
command: "/usr/bin/python3" "/checkout/src/etc/htmldocck.py" "/checkout/obj/build/x86_64-unknown-linux-gnu/test/rustdoc/auto-trait-bounds-where-51236" "/checkout/tests/rustdoc/auto-trait-bounds-where-51236.rs"
--- stderr -------------------------------
13: @has check failed
13: @has check failed
 `XPATH PATTERN` did not match
 // @has - '//*[@id="synthetic-implementations-list"]//*[@class="impl"]//h3[@class="code-header"]' "impl<T> Send for Owned<T>where <T as Owned<'static>>::Reader: Send"
Encountered 1 errors
------------------------------------------



---- [rustdoc] tests/rustdoc/auto-trait-bounds-by-associated-type-50159.rs stdout ----

error: htmldocck failed!
status: exit status: 1
command: "/usr/bin/python3" "/checkout/src/etc/htmldocck.py" "/checkout/obj/build/x86_64-unknown-linux-gnu/test/rustdoc/auto-trait-bounds-by-associated-type-50159" "/checkout/tests/rustdoc/auto-trait-bounds-by-associated-type-50159.rs"
--- stderr -------------------------------
20: @has check failed
20: @has check failed
 `XPATH PATTERN` did not match
 // @has - '//h3[@class="code-header"]' 'impl<B> Send for Switch<B>where <B as Signal>::Item: Send'
21: @has check failed
 `XPATH PATTERN` did not match
 // @has - '//h3[@class="code-header"]' 'impl<B> Sync for Switch<B>where <B as Signal>::Item: Sync'
Encountered 2 errors
------------------------------------------



---- [rustdoc] tests/rustdoc/bounds.rs stdout ----

error: htmldocck failed!
status: exit status: 1
command: "/usr/bin/python3" "/checkout/src/etc/htmldocck.py" "/checkout/obj/build/x86_64-unknown-linux-gnu/test/rustdoc/bounds" "/checkout/tests/rustdoc/bounds.rs"
--- stderr -------------------------------
8: @has check failed
8: @has check failed
 `XPATH PATTERN` did not match
 // @has - "//*[@id='tymethod.f']/h4" "fn f<'a, 'b, 'c, T>()where Self: Eq, T: Eq + 'a, 'c: 'b + 'a,"
16: @has check failed
 `XPATH PATTERN` did not match
 // @has - "//*[@id='tymethod.f']/h4" "fn f<T>()where Self: Eq + Eq2, T: Eq2 + Eq,"
27: @has check failed
 `XPATH PATTERN` did not match
 // @has - '//pre[@class="rust item-decl"]' "empty<'a, T>()where T:, 'a:,"
Encountered 3 errors
------------------------------------------



---- [rustdoc] tests/rustdoc/const-effect-param.rs stdout ----

error: htmldocck failed!
status: exit status: 1
command: "/usr/bin/python3" "/checkout/src/etc/htmldocck.py" "/checkout/obj/build/x86_64-unknown-linux-gnu/test/rustdoc/const-effect-param" "/checkout/tests/rustdoc/const-effect-param.rs"
--- stderr -------------------------------
12: @has check failed
12: @has check failed
 `XPATH PATTERN` did not match
 // @has - '//pre[@class="rust item-decl"]' 'pub const fn g<T: Tr>()'
Encountered 1 errors
------------------------------------------



---- [rustdoc] tests/rustdoc/const-generics/add-impl.rs stdout ----

error: htmldocck failed!
status: exit status: 1
command: "/usr/bin/python3" "/checkout/src/etc/htmldocck.py" "/checkout/obj/build/x86_64-unknown-linux-gnu/test/rustdoc/const-generics/add-impl" "/checkout/tests/rustdoc/const-generics/add-impl.rs"
--- stderr -------------------------------
5: @has check failed
5: @has check failed
 `XPATH PATTERN` did not match
 // @has foo/struct.Simd.html '//pre[@class="rust item-decl"]' 'pub struct Simd<T, const WIDTH: usize>'
Encountered 1 errors
------------------------------------------



---- [rustdoc] tests/rustdoc/const-generics/const-generic-defaults.rs stdout ----

error: htmldocck failed!
status: exit status: 1
command: "/usr/bin/python3" "/checkout/src/etc/htmldocck.py" "/checkout/obj/build/x86_64-unknown-linux-gnu/test/rustdoc/const-generics/const-generic-defaults" "/checkout/tests/rustdoc/const-generics/const-generic-defaults.rs"
--- stderr -------------------------------
3: @has check failed
3: @has check failed
 `XPATH PATTERN` did not match
 // @has foo/struct.Foo.html '//pre[@class="rust item-decl"]' 'pub struct Foo<const M: usize = 10, const N: usize = M, T = i32>('
Encountered 1 errors
------------------------------------------



---- [rustdoc] tests/rustdoc/const-intrinsic.rs stdout ----

error: htmldocck failed!
status: exit status: 1
command: "/usr/bin/python3" "/checkout/src/etc/htmldocck.py" "/checkout/obj/build/x86_64-unknown-linux-gnu/test/rustdoc/const-intrinsic" "/checkout/tests/rustdoc/const-intrinsic.rs"
--- stderr -------------------------------
9: @has check failed
9: @has check failed
 `XPATH PATTERN` did not match
     // @has - '//pre[@class="rust item-decl"]' 'pub const unsafe extern "rust-intrinsic" fn transmute<T, U>(_: T) -> U'
Encountered 1 errors
------------------------------------------



---- [rustdoc] tests/rustdoc/const-generics/const-impl.rs stdout ----

error: htmldocck failed!
status: exit status: 1
command: "/usr/bin/python3" "/checkout/src/etc/htmldocck.py" "/checkout/obj/build/x86_64-unknown-linux-gnu/test/rustdoc/const-generics/const-impl" "/checkout/tests/rustdoc/const-generics/const-impl.rs"
--- stderr -------------------------------
13: @has check failed
13: @has check failed
 `XPATH PATTERN` did not match
 // @has foo/struct.VSet.html '//pre[@class="rust item-decl"]' 'pub struct VSet<T, const ORDER: Order>'
14: @has check failed
 `XPATH PATTERN` did not match
 // @has foo/struct.VSet.html '//*[@id="impl-Send-for-VSet%3CT,+ORDER%3E"]/h3[@class="code-header"]' 'impl<T, const ORDER: Order> Send for VSet<T, ORDER>'
15: @has check failed
 `XPATH PATTERN` did not match
 // @has foo/struct.VSet.html '//*[@id="impl-Sync-for-VSet%3CT,+ORDER%3E"]/h3[@class="code-header"]' 'impl<T, const ORDER: Order> Sync for VSet<T, ORDER>'
Encountered 3 errors
------------------------------------------



---- [rustdoc] tests/rustdoc/const-generics/const-generics-docs.rs stdout ----

error: htmldocck failed!
status: exit status: 1
command: "/usr/bin/python3" "/checkout/src/etc/htmldocck.py" "/checkout/obj/build/x86_64-unknown-linux-gnu/test/rustdoc/const-generics/const-generics-docs" "/checkout/tests/rustdoc/const-generics/const-generics-docs.rs"
--- stderr -------------------------------
36: @has check failed
36: @has check failed
 `XPATH PATTERN` did not match
 // @has foo/struct.Bar.html '//pre[@class="rust item-decl"]' 'pub struct Bar<T, const N: usize>('
Encountered 1 errors
------------------------------------------



---- [rustdoc] tests/rustdoc/higher-ranked-trait-bounds.rs stdout ----

error: htmldocck failed!
status: exit status: 1
command: "/usr/bin/python3" "/checkout/src/etc/htmldocck.py" "/checkout/obj/build/x86_64-unknown-linux-gnu/test/rustdoc/higher-ranked-trait-bounds" "/checkout/tests/rustdoc/higher-ranked-trait-bounds.rs"
--- stderr -------------------------------
7: @has check failed
7: @has check failed
 `XPATH PATTERN` did not match
 // @has - '//pre' "pub fn test1<T>()where for<'a> &'a T: Iterator,"
15: @has check failed
 `XPATH PATTERN` did not match
 // @has - '//pre' "pub fn test2<T>()where for<'a, 'b> &'a T: Trait<'b>,"
23: @has check failed
 `XPATH PATTERN` did not match
 // @has - '//pre' "pub fn test3<F>()where F: for<'a, 'b> Fn(&'a u8, &'b u8),"
41: @has check failed
 `XPATH PATTERN` did not match
     // @has - '//h4[@class="code-header"]' "pub fn bar<T>()where T: Trait<'a>,"
Encountered 4 errors
------------------------------------------



---- [rustdoc] tests/rustdoc/inline_cross/const-effect-param.rs stdout ----

error: htmldocck failed!
status: exit status: 1
command: "/usr/bin/python3" "/checkout/src/etc/htmldocck.py" "/checkout/obj/build/x86_64-unknown-linux-gnu/test/rustdoc/inline_cross/const-effect-param" "/checkout/tests/rustdoc/inline_cross/const-effect-param.rs"
--- stderr -------------------------------
10: @has check failed
10: @has check failed
 `XPATH PATTERN` did not match
 // @has - '//pre[@class="rust item-decl"]' "pub const fn load<R>() -> i32where R: Resource"
17: @has check failed
 `XPATH PATTERN` did not match
 // @has - '//pre[@class="rust item-decl"]' "pub const fn lock<R>()where R: Resource"
25: @has check failed
 `XPATH PATTERN` did not match
 // @has - '//pre[@class="rust item-decl"]' "pub const fn clash<T, const host: u64>()where T: Clash<host>"
Encountered 3 errors
------------------------------------------



---- [rustdoc] tests/rustdoc/inline_cross/dyn_trait.rs stdout ----

error: htmldocck failed!
status: exit status: 1
command: "/usr/bin/python3" "/checkout/src/etc/htmldocck.py" "/checkout/obj/build/x86_64-unknown-linux-gnu/test/rustdoc/inline_cross/dyn_trait" "/checkout/tests/rustdoc/inline_cross/dyn_trait.rs"
--- stderr -------------------------------
56: @has check failed
56: @has check failed
 `XPATH PATTERN` did not match
 // @has - '//pre[@class="rust item-decl"]' "lbwe<'e, 'l>(_: Ref<'l, dyn Trait + 'e>)"
Encountered 1 errors
------------------------------------------



---- [rustdoc] tests/rustdoc/inline_cross/early-late-bound-lifetime-params.rs stdout ----

error: htmldocck failed!
status: exit status: 1
command: "/usr/bin/python3" "/checkout/src/etc/htmldocck.py" "/checkout/obj/build/x86_64-unknown-linux-gnu/test/rustdoc/inline_cross/early-late-bound-lifetime-params" "/checkout/tests/rustdoc/inline_cross/early-late-bound-lifetime-params.rs"
--- stderr -------------------------------
12: @has check failed
12: @has check failed
 `XPATH PATTERN` did not match
 // @has - '//pre[@class="rust item-decl"]' "fn f<'a, 'b, 'c, 'd, T, const N: usize>(_: impl Copy)"
16: @has check failed
 `XPATH PATTERN` did not match
 // @has - '//*[@id="method.f"]' "fn f<'a, 'b, 'c, 'd, T, const N: usize>(_: impl Copy)"
Encountered 2 errors
------------------------------------------



---- [rustdoc] tests/rustdoc/inline_cross/assoc_item_trait_bounds.rs stdout ----

error: htmldocck failed!
status: exit status: 1
command: "/usr/bin/python3" "/checkout/src/etc/htmldocck.py" "/checkout/obj/build/x86_64-unknown-linux-gnu/test/rustdoc/inline_cross/assoc_item_trait_bounds" "/checkout/tests/rustdoc/inline_cross/assoc_item_trait_bounds.rs"
--- stderr -------------------------------
35: @has check failed
35: @has check failed
 `XPATH PATTERN` did not match
 // @has - '//*[@id="tymethod.make"]' "fn make<F>(_: F, _: impl FnMut(&str) -> bool)where F: FnOnce(u32) -> String, Self::Out2<()>: Protocol<u8, Q0 = Self::Item, Q1 = ()>"
Encountered 1 errors
------------------------------------------



---- [rustdoc] tests/rustdoc/inline_cross/impl-sized.rs stdout ----

error: htmldocck failed!
status: exit status: 1
command: "/usr/bin/python3" "/checkout/src/etc/htmldocck.py" "/checkout/obj/build/x86_64-unknown-linux-gnu/test/rustdoc/inline_cross/impl-sized" "/checkout/tests/rustdoc/inline_cross/impl-sized.rs"
--- stderr -------------------------------
11: @has check failed
11: @has check failed
 `XPATH PATTERN` did not match
 // @has - '//pre[@class="rust item-decl"]' "sized_outlives<'a>(x: impl Sized + 'a) -> impl Sized + 'a"
25: @has check failed
 `XPATH PATTERN` did not match
 // @has - '//pre[@class="rust item-decl"]' "maybe_sized_outlives<'t>(x: &(impl ?Sized + 't)) -> &(impl ?Sized + 't)"
Encountered 2 errors
------------------------------------------



---- [rustdoc] tests/rustdoc/inline_cross/impl_trait.rs stdout ----

error: htmldocck failed!
status: exit status: 1
command: "/usr/bin/python3" "/checkout/src/etc/htmldocck.py" "/checkout/obj/build/x86_64-unknown-linux-gnu/test/rustdoc/inline_cross/impl_trait" "/checkout/tests/rustdoc/inline_cross/impl_trait.rs"
--- stderr -------------------------------
7: @has check failed
7: @has check failed
 `XPATH PATTERN` did not match
 // @has - '//pre[@class="rust item-decl"]' "pub fn func<'a>(_x: impl Clone + Into<Vec<u8>> + 'a)"
12: @has check failed
 `XPATH PATTERN` did not match
 // @has - '//pre[@class="rust item-decl"]' "func2<T>("
25: @has check failed
 `XPATH PATTERN` did not match
 // @has - '//pre[@class="rust item-decl"]' "func4<T>("
37: @has check failed
 `XPATH PATTERN` did not match
 // @has - '//*[@id="method.method"]//h4[@class="code-header"]' "pub fn method<'a>(_x: impl Clone + Into<Vec<u8>> + 'a)"
Encountered 4 errors
------------------------------------------



---- [rustdoc] tests/rustdoc/inline_cross/non_lifetime_binders.rs stdout ----

error: htmldocck failed!
status: exit status: 1
command: "/usr/bin/python3" "/checkout/src/etc/htmldocck.py" "/checkout/obj/build/x86_64-unknown-linux-gnu/test/rustdoc/inline_cross/non_lifetime_binders" "/checkout/tests/rustdoc/inline_cross/non_lifetime_binders.rs"
--- stderr -------------------------------
10: @has check failed
10: @has check failed
 `XPATH PATTERN` did not match
 // @has - '//pre[@class="rust item-decl"]' "g<T>(_: T)where T: for<U> Trait<U>"
Encountered 1 errors
------------------------------------------



---- [rustdoc] tests/rustdoc/inline_cross/sugar-closure-crate-21801.rs stdout ----

error: htmldocck failed!
status: exit status: 1
command: "/usr/bin/python3" "/checkout/src/etc/htmldocck.py" "/checkout/obj/build/x86_64-unknown-linux-gnu/test/rustdoc/inline_cross/sugar-closure-crate-21801" "/checkout/tests/rustdoc/inline_cross/sugar-closure-crate-21801.rs"
--- stderr -------------------------------
10: @has check failed
10: @has check failed
 `XPATH PATTERN` did not match
 // @has - '//*[@id="method.new"]' 'fn new<F>(f: F) -> Foowhere F: FnMut() -> i32'
Encountered 1 errors
------------------------------------------



---- [rustdoc] tests/rustdoc/inline_cross/ret-pos-impl-trait-in-trait.rs stdout ----

error: htmldocck failed!
status: exit status: 1
command: "/usr/bin/python3" "/checkout/src/etc/htmldocck.py" "/checkout/obj/build/x86_64-unknown-linux-gnu/test/rustdoc/inline_cross/ret-pos-impl-trait-in-trait" "/checkout/tests/rustdoc/inline_cross/ret-pos-impl-trait-in-trait.rs"
--- stderr -------------------------------
34: @has check failed
34: @has check failed
 `XPATH PATTERN` did not match
 // @has - '//*[@id="method.def"]' 'fn def<T>() -> impl Default'
Encountered 1 errors
------------------------------------------



---- [rustdoc] tests/rustdoc/issue-56822.rs stdout ----

error: htmldocck failed!
status: exit status: 1
command: "/usr/bin/python3" "/checkout/src/etc/htmldocck.py" "/checkout/obj/build/x86_64-unknown-linux-gnu/test/rustdoc/issue-56822" "/checkout/tests/rustdoc/issue-56822.rs"
--- stderr -------------------------------
20: @has check failed
20: @has check failed
 `XPATH PATTERN` did not match
 // @has - '//*[@id="synthetic-implementations-list"]//*[@class="impl"]//h3[@class="code-header"]' "impl<'a> Send for Parser<'a>"
Encountered 1 errors
------------------------------------------



---- [rustdoc] tests/rustdoc/issue-60726.rs stdout ----

error: htmldocck failed!
status: exit status: 1
command: "/usr/bin/python3" "/checkout/src/etc/htmldocck.py" "/checkout/obj/build/x86_64-unknown-linux-gnu/test/rustdoc/issue-60726" "/checkout/tests/rustdoc/issue-60726.rs"
--- stderr -------------------------------
29: @has check failed
29: @has check failed
 `XPATH PATTERN` did not match
 // @has - '//*[@id="synthetic-implementations-list"]//*[@class="impl"]//h3[@class="code-header"]' "impl<T> !Send for IntoIter<T>"
31: @has check failed
 `XPATH PATTERN` did not match
 // @has - '//*[@id="synthetic-implementations-list"]//*[@class="impl"]//h3[@class="code-header"]' "impl<T> !Sync for IntoIter<T>"
Encountered 2 errors
------------------------------------------



---- [rustdoc] tests/rustdoc/issue-80233-normalize-auto-trait.rs stdout ----

error: htmldocck failed!
status: exit status: 1
command: "/usr/bin/python3" "/checkout/src/etc/htmldocck.py" "/checkout/obj/build/x86_64-unknown-linux-gnu/test/rustdoc/issue-80233-normalize-auto-trait" "/checkout/tests/rustdoc/issue-80233-normalize-auto-trait.rs"
--- stderr -------------------------------
34: @has check failed
34: @has check failed
 `XPATH PATTERN` did not match
 // @has - '//h3[@class="code-header"]' 'impl<T> Send for Question<T>'
Encountered 1 errors
------------------------------------------



---- [rustdoc] tests/rustdoc/issue-81141-private-reexport-in-public-api-generics.rs stdout ----

error: htmldocck failed!
status: exit status: 1
command: "/usr/bin/python3" "/checkout/src/etc/htmldocck.py" "/checkout/obj/build/x86_64-unknown-linux-gnu/test/rustdoc/issue-81141-private-reexport-in-public-api-generics" "/checkout/tests/rustdoc/issue-81141-private-reexport-in-public-api-generics.rs"
--- stderr -------------------------------
10: @has check failed
10: @has check failed
 `XPATH PATTERN` did not match
 // @has - '//*[@class="rust item-decl"]/code' "pub fn foo<'a, T>(f: Foo<'a, T>) -> Foo<'a, usize>"
Encountered 1 errors
------------------------------------------



---- [rustdoc] tests/rustdoc/issue-98697.rs stdout ----

error: htmldocck failed!
status: exit status: 1
command: "/usr/bin/python3" "/checkout/src/etc/htmldocck.py" "/checkout/obj/build/x86_64-unknown-linux-gnu/test/rustdoc/issue-98697" "/checkout/tests/rustdoc/issue-98697.rs"
--- stderr -------------------------------

@bors
Copy link
Contributor

bors commented Apr 2, 2024

☔ The latest upstream changes (presumably #123340) made this pull request unmergeable. Please resolve the merge conflicts.

@Dylan-DPC Dylan-DPC removed the S-waiting-on-team Status: Awaiting decision from the relevant subteam (see the T-<team> label). label May 5, 2024
@Dylan-DPC Dylan-DPC added the S-tracking-design-concerns Status: There are blocking design concerns. label Oct 15, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
A-rustdoc-json Area: Rustdoc JSON backend needs-fcp This change is insta-stable, so needs a completed FCP to proceed. S-blocked Status: Blocked on something else such as an RFC or other implementation work. S-tracking-design-concerns Status: There are blocking design concerns. T-rustdoc Relevant to the rustdoc team, which will review and decide on the PR/issue.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Rustdoc should indicate variance on lifetime/type parameters
5 participants