Various rustc_codegen_ssa cleanups #123237

bjorn3 · 2024-03-30T14:52:19Z

No description provided.

rustbot · 2024-03-30T14:52:27Z

rustbot has assigned @estebank.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

rustbot · 2024-03-30T14:52:29Z

Some changes occurred in compiler/rustc_codegen_gcc

cc @antoyo, @GuillaumeGomez

matthiaskrgr · 2024-03-30T14:56:57Z

compiler/rustc_codegen_gcc/src/common.rs

+                if pointee.dyncast_vector().is_some() {
+                    panic!()
+                }


this could be an assert!()?

This is just moving some code around.

bors · 2024-06-17T22:02:42Z

☔ The latest upstream changes (presumably #126605) made this pull request unmergeable. Please resolve the merge conflicts.

…eneration method

It is only implemented for a single type. Directly passing this type is simpler and avoids overhead from indirect calls.

It can be retrieved from the Session too.

They are not representable by Cranelift

wesleywiser · 2024-06-27T14:36:17Z

r? rust-lang/compiler

compiler-errors · 2024-06-27T14:41:48Z

r? compiler-errors @bors r+

bors · 2024-06-27T14:41:51Z

📌 Commit 84f45bb has been approved by compiler-errors

It is now in the queue for this repository.

…ler-errors Various rustc_codegen_ssa cleanups

…llaumeGomez Rollup of 10 pull requests Successful merges: - rust-lang#123237 (Various rustc_codegen_ssa cleanups) - rust-lang#123714 (Add test for fn pointer duplication.) - rust-lang#124091 (Update AST validation module docs) - rust-lang#126835 (Simplifications in match lowering) - rust-lang#126963 (Add basic Serde serialization capabilities to Stable MIR) - rust-lang#127010 (Update browser-ui-test version to `0.18.0`) - rust-lang#127015 (Switch back `non_local_definitions` lint to allow-by-default) - rust-lang#127016 (docs: check if the disambiguator matches its suffix) - rust-lang#127029 (Fix Markdown tables in platform-support.md) - rust-lang#127032 (Enable const casting for `f16` and `f128`) r? `@ghost` `@rustbot` modify labels: rollup

…ler-errors Various rustc_codegen_ssa cleanups

…iaskrgr Rollup of 9 pull requests Successful merges: - rust-lang#123237 (Various rustc_codegen_ssa cleanups) - rust-lang#123714 (Add test for fn pointer duplication.) - rust-lang#124091 (Update AST validation module docs) - rust-lang#126835 (Simplifications in match lowering) - rust-lang#126963 (Add basic Serde serialization capabilities to Stable MIR) - rust-lang#127010 (Update browser-ui-test version to `0.18.0`) - rust-lang#127015 (Switch back `non_local_definitions` lint to allow-by-default) - rust-lang#127029 (Fix Markdown tables in platform-support.md) - rust-lang#127032 (Enable const casting for `f16` and `f128`) r? `@ghost` `@rustbot` modify labels: rollup

…ler-errors Various rustc_codegen_ssa cleanups

…iaskrgr Rollup of 8 pull requests Successful merges: - rust-lang#123237 (Various rustc_codegen_ssa cleanups) - rust-lang#123714 (Add test for fn pointer duplication.) - rust-lang#124091 (Update AST validation module docs) - rust-lang#126835 (Simplifications in match lowering) - rust-lang#126963 (Add basic Serde serialization capabilities to Stable MIR) - rust-lang#127015 (Switch back `non_local_definitions` lint to allow-by-default) - rust-lang#127029 (Fix Markdown tables in platform-support.md) - rust-lang#127032 (Enable const casting for `f16` and `f128`) r? `@ghost` `@rustbot` modify labels: rollup

tgross35 · 2024-06-28T04:43:53Z

Any chance this could have failed the rollup with #127066 (comment)? That same error happened in another rollup too. Seems unlikely, but nothing else seems more likely

…iaskrgr Rollup of 8 pull requests Successful merges: - rust-lang#123237 (Various rustc_codegen_ssa cleanups) - rust-lang#123714 (Add test for fn pointer duplication.) - rust-lang#124091 (Update AST validation module docs) - rust-lang#126835 (Simplifications in match lowering) - rust-lang#126963 (Add basic Serde serialization capabilities to Stable MIR) - rust-lang#127015 (Switch back `non_local_definitions` lint to allow-by-default) - rust-lang#127029 (Fix Markdown tables in platform-support.md) - rust-lang#127032 (Enable const casting for `f16` and `f128`) r? `@ghost` `@rustbot` modify labels: rollup

bjorn3 · 2024-06-28T10:40:37Z

The failing test seems to be

// foo.rs

// This is kept because of `#[used]`:
#[used]
static FOO: u32 = 0;

// This is removable because it is unused:
#[allow(dead_code)]
static BAR: u32 = 0;

// This is kept because it is publicly reachable:
pub static BAZ: u32 = 0;

// This is kept because it is referenced by a public, reachable function:
static QUUX: u32 = 0;

pub fn quux() -> &'static u32 {
    &QUUX
}

// This is removable because it is referenced by a private, unused (dead) function:
static CORGE: u32 = 0;

#[allow(dead_code)]
fn corge() -> &'static u32 {
    &CORGE
}

Maybe #127052 is related given that this uses #[used]?

…iaskrgr Rollup of 8 pull requests Successful merges: - rust-lang#123237 (Various rustc_codegen_ssa cleanups) - rust-lang#123714 (Add test for fn pointer duplication.) - rust-lang#124091 (Update AST validation module docs) - rust-lang#126835 (Simplifications in match lowering) - rust-lang#126963 (Add basic Serde serialization capabilities to Stable MIR) - rust-lang#127015 (Switch back `non_local_definitions` lint to allow-by-default) - rust-lang#127029 (Fix Markdown tables in platform-support.md) - rust-lang#127032 (Enable const casting for `f16` and `f128`) r? `@ghost` `@rustbot` modify labels: rollup

…ler-errors Various rustc_codegen_ssa cleanups

…iaskrgr Rollup of 9 pull requests Successful merges: - rust-lang#123237 (Various rustc_codegen_ssa cleanups) - rust-lang#126960 (Improve error message in tidy) - rust-lang#127002 (Implement `x perf` as a separate tool) - rust-lang#127050 (Make mtime of reproducible tarballs dependent on git commit) - rust-lang#127081 (Add a run-make test that LLD is not being used by default on the x64 beta/stable channel) - rust-lang#127106 (Improve unsafe extern blocks diagnostics) - rust-lang#127110 (Fix a error suggestion for E0121 when using placeholder _ as return types on function signature.) - rust-lang#127114 (fix: prefer `(*p).clone` to `p.clone` if the `p` is a raw pointer) - rust-lang#127118 (Show `used attribute`'s kind for user when find it isn't applied to a `static` variable.) r? `@ghost` `@rustbot` modify labels: rollup

…iaskrgr Rollup of 9 pull requests Successful merges: - rust-lang#123237 (Various rustc_codegen_ssa cleanups) - rust-lang#126960 (Improve error message in tidy) - rust-lang#127002 (Implement `x perf` as a separate tool) - rust-lang#127081 (Add a run-make test that LLD is not being used by default on the x64 beta/stable channel) - rust-lang#127106 (Improve unsafe extern blocks diagnostics) - rust-lang#127110 (Fix a error suggestion for E0121 when using placeholder _ as return types on function signature.) - rust-lang#127114 (fix: prefer `(*p).clone` to `p.clone` if the `p` is a raw pointer) - rust-lang#127118 (Show `used attribute`'s kind for user when find it isn't applied to a `static` variable.) - rust-lang#127122 (Remove uneccessary condition in `div_ceil`) r? `@ghost` `@rustbot` modify labels: rollup

Rollup merge of rust-lang#123237 - bjorn3:debuginfo_refactor, r=compiler-errors Various rustc_codegen_ssa cleanups

rustbot assigned estebank Mar 30, 2024

rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. labels Mar 30, 2024

matthiaskrgr reviewed Mar 30, 2024

View reviewed changes

This comment has been minimized.

Sign in to view

bjorn3 added 8 commits June 21, 2024 19:26

Move vcall_visibility_metadata optimization hint out of a debuginfo g…

e9ea578

…eneration method

Remove PrintBackendInfo trait

7f44532

It is only implemented for a single type. Directly passing this type is simpler and avoids overhead from indirect calls.

Remove const_bitcast from ConstMethods

98e8601

Dedup some intrinsic handling code for caller_location

e32eb4c

Move all intrinsic handling code in codegen_call_terminators together

22b3243

Remove check_overflow method from MiscMethods

aacdce3

It can be retrieved from the Session too.

Remove type_i1 and type_struct from cg_ssa

887f57f

They are not representable by Cranelift

Fix doc comment

84f45bb

bjorn3 force-pushed the debuginfo_refactor branch from aa050c7 to 84f45bb Compare June 21, 2024 19:33

rustbot assigned davidtwco and unassigned estebank Jun 27, 2024

compiler-errors approved these changes Jun 27, 2024

View reviewed changes

rustbot assigned compiler-errors Jun 27, 2024

bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jun 27, 2024

rustbot unassigned davidtwco Jun 27, 2024

GuillaumeGomez added a commit to GuillaumeGomez/rust that referenced this pull request Jun 27, 2024

Rollup merge of rust-lang#123237 - bjorn3:debuginfo_refactor, r=compi…

0c08062

…ler-errors Various rustc_codegen_ssa cleanups

GuillaumeGomez mentioned this pull request Jun 27, 2024

Rollup of 10 pull requests #127046

Closed

matthiaskrgr added a commit to matthiaskrgr/rust that referenced this pull request Jun 27, 2024

Rollup merge of rust-lang#123237 - bjorn3:debuginfo_refactor, r=compi…

ab690fe

…ler-errors Various rustc_codegen_ssa cleanups

matthiaskrgr mentioned this pull request Jun 27, 2024

Rollup of 9 pull requests #127056

Closed

matthiaskrgr added a commit to matthiaskrgr/rust that referenced this pull request Jun 28, 2024

Rollup merge of rust-lang#123237 - bjorn3:debuginfo_refactor, r=compi…

a12e47c

…ler-errors Various rustc_codegen_ssa cleanups

matthiaskrgr mentioned this pull request Jun 28, 2024

Rollup of 8 pull requests #127066

Closed

matthiaskrgr added a commit to matthiaskrgr/rust that referenced this pull request Jun 29, 2024

Rollup merge of rust-lang#123237 - bjorn3:debuginfo_refactor, r=compi…

31eed5d

…ler-errors Various rustc_codegen_ssa cleanups

matthiaskrgr mentioned this pull request Jun 29, 2024

Rollup of 9 pull requests #127125

Closed

matthiaskrgr mentioned this pull request Jun 29, 2024

Rollup of 9 pull requests #127133

Merged

bors merged commit 5b90824 into rust-lang:master Jun 30, 2024

rustbot added this to the 1.81.0 milestone Jun 30, 2024

rust-timer added a commit to rust-lang-ci/rust that referenced this pull request Jun 30, 2024

Unrolled build for rust-lang#123237

6d99c36

Rollup merge of rust-lang#123237 - bjorn3:debuginfo_refactor, r=compiler-errors Various rustc_codegen_ssa cleanups

bjorn3 deleted the debuginfo_refactor branch June 30, 2024 10:34

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Various rustc_codegen_ssa cleanups #123237

Various rustc_codegen_ssa cleanups #123237

Uh oh!

bjorn3 commented Mar 30, 2024

Uh oh!

rustbot commented Mar 30, 2024

Uh oh!

rustbot commented Mar 30, 2024

Uh oh!

matthiaskrgr Mar 30, 2024

Uh oh!

bjorn3 Mar 30, 2024

Uh oh!

This comment has been minimized.

bors commented Jun 17, 2024

Uh oh!

wesleywiser commented Jun 27, 2024

Uh oh!

compiler-errors commented Jun 27, 2024

Uh oh!

bors commented Jun 27, 2024

Uh oh!

tgross35 commented Jun 28, 2024

Uh oh!

bjorn3 commented Jun 28, 2024

Uh oh!

Uh oh!

Various rustc_codegen_ssa cleanups #123237

Various rustc_codegen_ssa cleanups #123237

Uh oh!

Conversation

bjorn3 commented Mar 30, 2024

Uh oh!

rustbot commented Mar 30, 2024

Uh oh!

rustbot commented Mar 30, 2024

Uh oh!

matthiaskrgr Mar 30, 2024

Choose a reason for hiding this comment

Uh oh!

bjorn3 Mar 30, 2024

Choose a reason for hiding this comment

Uh oh!

This comment has been minimized.

bors commented Jun 17, 2024

Uh oh!

wesleywiser commented Jun 27, 2024

Uh oh!

compiler-errors commented Jun 27, 2024

Uh oh!

bors commented Jun 27, 2024

Uh oh!

tgross35 commented Jun 28, 2024

Uh oh!

bjorn3 commented Jun 28, 2024

Uh oh!

Uh oh!