Move std::num::Integer to libnum #12326
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I'm in favor of this. It seems odd to me for libstd to have both |
|
It made more sense when we had a distinction between |
|
I'm in favor of this change as well. I'm happy to sy |
|
Let's do this. |
|
(as in, with a rebase I'll review and r+) |
|
@alexcrichton rebased. |
bors
added a commit
that referenced
this pull request
Feb 21, 2014
This is part of the effort to simplify `std::num`, as tracked in issue #10387.
|
\o/ |
bors
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Jul 25, 2022
…t, r=jonas-schievink feat: Add "cargo clippy" task preset We've had a couple of common presets in `Tasks: Run Task -> cargo -> cargo [check,build,test,...]` before. This PR adds `cargo clippy` to that list, which makes for a convenient way of occasionally running Clippy on your code without having to reconfigure the Check on Save command to clippy. These presets all use the `cargo` task type that we provide, so diagnostics will show up in the editor. However, they don't go through the server-side parsing logic, so it's not possible to apply suggestions, and diagnostics are fairly "low-fidelity". It would be cool if we could somehow pass Cargo's JSON output through the LSP server and render it properly, for arbitrary tasks. cc rust-lang/rust-analyzer#12323
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is part of the effort to simplify
std::num, as tracked in issue #10387.