-
Notifications
You must be signed in to change notification settings - Fork 13.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Refactor collections::list #12348
Merged
bors
merged 18 commits into
rust-lang:master
from
brunoabinader:libcollections-list-refactory
Feb 28, 2014
+177
−217
Merged
Refactor collections::list #12348
Changes from all commits
Commits
Show all changes
18 commits
Select commit
Hold shift + click to select a range
4c553af
Replaced @List with ~List in Rust's recursive example
brunoabinader 1e6151a
Renamed variables
brunoabinader 8846970
Implement Eq for Cell<T>
brunoabinader 2b36276
Modified list::from_vec() to return List<T>
brunoabinader 52524bf
Implemented Items<'a, T> for List<T>
brunoabinader 0c8731e
Replaced list::each with iter() in Arenas's Drop impl
brunoabinader 43bc6fc
Replaced list::each with iter() in get_region
brunoabinader a09a4b8
Removed list::foldl() in favor of iter().fold()
brunoabinader d681907
Removed list::find() in favor of iter().find()
brunoabinader 197116d
Removed list::any() in favor of iter().any()
brunoabinader e589fcf
Implemented list::len() based on Container trait
brunoabinader a14d72d
Implemented list::is_empty() based on Container trait
brunoabinader 223f309
Removed deprecated list::{iter,each}() functions
brunoabinader 45fd63a
Replaced list::has() with list::contains()
brunoabinader fed034c
Refactored list::head() to be based on List<T>
brunoabinader 65f1993
Refactored list::tail() to be based on List<T>
brunoabinader 1c27c90
Refactored list::append() to be based on List<T>
brunoabinader 4da6d04
Replaced list::push() with unshift() based on List<T>
brunoabinader File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why change this part of the tutorial?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
As @eddyb mentioned on #servo, it would be nice to replace
@List<T>
with some other kind of garbage-collected container (likeRc<T>
), but it wouldn't need to mess with the tutorial.ps: However, I was told that @ is going to be deprecated soon, so we may change it later on anyways.