Fix ICE in `eval_body_using_ecx` #123491

gurry · 2024-04-05T09:46:24Z

Ensures TypeckResults is tainted by failing candidate assembly for types with error

rustbot · 2024-04-05T09:46:31Z

rustbot has assigned @BoxyUwU.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

compiler/rustc_const_eval/src/const_eval/eval_queries.rs

BoxyUwU · 2024-04-05T17:36:02Z

r? @oli-obk (?)

compiler/rustc_ty_utils/src/ty.rs

compiler/rustc_trait_selection/src/traits/select/candidate_assembly.rs

compiler/rustc_trait_selection/src/traits/error_reporting/type_err_ctxt_ext.rs

compiler/rustc_trait_selection/src/traits/select/candidate_assembly.rs

oli-obk · 2024-04-15T08:46:39Z

@bors r+ rollup

bors · 2024-04-15T08:46:41Z

📌 Commit 4ee780a has been approved by oli-obk

It is now in the queue for this repository.

…al, r=oli-obk Fix ICE in `eval_body_using_ecx` Ensures `TypeckResults` is tainted by failing candidate assembly for types with error Fixes rust-lang#123154

jieyouxu · 2024-04-15T15:54:45Z

Failed in rollup because the corresponding ICE test in the new crashes test suite https://github.com/rust-lang/rust/blob/84e729a59f216cc64755788a470f165429a731f4/tests/crashes/123154.rs is no longer ICEing (i.e. this PR fixed it). Please move this test from tests/crashes to tests/ui, or remove the test if a substitute test is available.

See #123966 (comment).

@bors r-

gurry · 2024-04-16T07:10:43Z

Failed in rollup because the corresponding ICE test in the new crashes test suite https://github.com/rust-lang/rust/blob/84e729a59f216cc64755788a470f165429a731f4/tests/crashes/123154.rs is no longer ICEing (i.e. this PR fixed it). Please move this test from tests/crashes to tests/ui, or remove the test if a substitute test is available.

See #123966 (comment).

Thanks @jieyouxu

I have already added the exact same code as my test for this fix under tests/ui so I'll remove it from tests/crashes.

Can I just say that tracking all the ICEs within rustc is such a great idea!

Trait predicates for types which have errors may still evaluate to OK leading to downstream ICEs. Now we return a selection error for such types in candidate assembly and thereby prevent such issues

oli-obk · 2024-04-16T08:04:48Z

@bors r+ rollup

bors · 2024-04-16T08:04:51Z

📌 Commit c30e15a has been approved by oli-obk

It is now in the queue for this repository.

…llaumeGomez Rollup of 14 pull requests Successful merges: - rust-lang#120781 (Correct usage note on OpenOptions::append()) - rust-lang#121694 (sess: stabilize `-Zrelro-level` as `-Crelro-level`) - rust-lang#122521 (doc(bootstrap): add top-level doc-comment to utils/tarball.rs) - rust-lang#123491 (Fix ICE in `eval_body_using_ecx`) - rust-lang#123574 (rustdoc: rename `issue-\d+.rs` tests to have meaningful names (part 6)) - rust-lang#123687 (Update ar_archive_writer to 0.2.0) - rust-lang#123721 (Various visionOS fixes) - rust-lang#123797 (Better graphviz output for SCCs and NLL constraints) - rust-lang#123990 (Make `suggest_deref_closure_return` more idiomatic/easier to understand) - rust-lang#123995 (Make `thir_tree` and `thir_flat` into hooks) - rust-lang#123998 (Opaque types have no namespace) - rust-lang#124001 (Fix docs for unstable_features lint.) - rust-lang#124006 (Move size assertions for `mir::syntax` types into the same file) - rust-lang#124011 (rustdoc: update the module-level docs of `rustdoc::clean`) r? `@ghost` `@rustbot` modify labels: rollup

Rollup merge of rust-lang#123491 - gurry:123154-ice-unsized-struct-eval, r=oli-obk Fix ICE in `eval_body_using_ecx` Ensures `TypeckResults` is tainted by failing candidate assembly for types with error Fixes rust-lang#123154

…r=Nadrieril Fix ICE while casting a type with error Fixes rust-lang#124848 The ICE originates here: https://github.com/rust-lang/rust/blob/f9a3fd966162b3c7386d90fe4626471f66ba3b8f/compiler/rustc_hir_typeck/src/cast.rs#L143 The underlying cause is that a type with error, `MyType` was involved in a cast. During cast checks the below method `pointer_kind` was called: https://github.com/rust-lang/rust/blob/f9a3fd966162b3c7386d90fe4626471f66ba3b8f/compiler/rustc_hir_typeck/src/cast.rs#L87-L91 Thanks to the changes in PR rust-lang#123491, `type_is_sized_modulo_regions` in `pointer_kind` returned `false` which caused control to reach the `span_bug` here: https://github.com/rust-lang/rust/blob/f9a3fd966162b3c7386d90fe4626471f66ba3b8f/compiler/rustc_hir_typeck/src/cast.rs#L143 resulting in an ICE. This PR fixes the issue by changing the `span_bug` to a `span_delayed_bug`.

Rollup merge of rust-lang#124997 - gurry:124848-ice-should-be-sized, r=Nadrieril Fix ICE while casting a type with error Fixes rust-lang#124848 The ICE originates here: https://github.com/rust-lang/rust/blob/f9a3fd966162b3c7386d90fe4626471f66ba3b8f/compiler/rustc_hir_typeck/src/cast.rs#L143 The underlying cause is that a type with error, `MyType` was involved in a cast. During cast checks the below method `pointer_kind` was called: https://github.com/rust-lang/rust/blob/f9a3fd966162b3c7386d90fe4626471f66ba3b8f/compiler/rustc_hir_typeck/src/cast.rs#L87-L91 Thanks to the changes in PR rust-lang#123491, `type_is_sized_modulo_regions` in `pointer_kind` returned `false` which caused control to reach the `span_bug` here: https://github.com/rust-lang/rust/blob/f9a3fd966162b3c7386d90fe4626471f66ba3b8f/compiler/rustc_hir_typeck/src/cast.rs#L143 resulting in an ICE. This PR fixes the issue by changing the `span_bug` to a `span_delayed_bug`.

rustbot assigned BoxyUwU Apr 5, 2024

rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. labels Apr 5, 2024

gurry commented Apr 5, 2024

View reviewed changes

compiler/rustc_const_eval/src/const_eval/eval_queries.rs Outdated Show resolved Hide resolved

BoxyUwU approved these changes Apr 5, 2024

View reviewed changes

rustbot assigned oli-obk and unassigned BoxyUwU Apr 5, 2024

gurry force-pushed the 123154-ice-unsized-struct-eval branch from f718480 to 71c64ed Compare April 13, 2024 06:07

This comment has been minimized.

Sign in to view

oli-obk reviewed Apr 13, 2024

View reviewed changes

compiler/rustc_ty_utils/src/ty.rs Outdated Show resolved Hide resolved

oli-obk reviewed Apr 13, 2024

View reviewed changes

compiler/rustc_ty_utils/src/ty.rs Outdated Show resolved Hide resolved

gurry force-pushed the 123154-ice-unsized-struct-eval branch from 71c64ed to f4ad462 Compare April 13, 2024 10:17

oli-obk reviewed Apr 13, 2024

View reviewed changes

compiler/rustc_trait_selection/src/traits/select/candidate_assembly.rs Outdated Show resolved Hide resolved

oli-obk reviewed Apr 13, 2024

View reviewed changes

compiler/rustc_trait_selection/src/traits/select/candidate_assembly.rs Outdated Show resolved Hide resolved

This comment has been minimized.

Sign in to view

gurry force-pushed the 123154-ice-unsized-struct-eval branch from f4ad462 to 2783775 Compare April 13, 2024 11:52

This comment has been minimized.

Sign in to view

gurry force-pushed the 123154-ice-unsized-struct-eval branch 2 times, most recently from 5ebc975 to 89e74af Compare April 15, 2024 04:58

gurry commented Apr 15, 2024

View reviewed changes

compiler/rustc_trait_selection/src/traits/error_reporting/type_err_ctxt_ext.rs Show resolved Hide resolved

This comment has been minimized.

Sign in to view

oli-obk reviewed Apr 15, 2024

View reviewed changes

compiler/rustc_trait_selection/src/traits/select/candidate_assembly.rs Show resolved Hide resolved

gurry force-pushed the 123154-ice-unsized-struct-eval branch from 89e74af to 4ee780a Compare April 15, 2024 07:52

bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Apr 15, 2024

jieyouxu mentioned this pull request Apr 15, 2024

Rollup of 13 pull requests #123966

Closed

bors added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Apr 15, 2024

Fail candidate assembly for erroneous types

c30e15a

Trait predicates for types which have errors may still evaluate to OK leading to downstream ICEs. Now we return a selection error for such types in candidate assembly and thereby prevent such issues

gurry force-pushed the 123154-ice-unsized-struct-eval branch from 4ee780a to c30e15a Compare April 16, 2024 07:14

bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Apr 16, 2024

GuillaumeGomez mentioned this pull request Apr 16, 2024

Rollup of 14 pull requests #124015

Merged

bors merged commit ea7eb71 into rust-lang:master Apr 16, 2024
12 checks passed

rustbot added this to the 1.79.0 milestone Apr 16, 2024

matthiaskrgr mentioned this pull request Apr 16, 2024

ICE: layout errored yet tail '{type error}' is not a type parameter or a projection #124031

Closed

gurry deleted the 123154-ice-unsized-struct-eval branch April 17, 2024 06:06

gurry mentioned this pull request Apr 21, 2024

Spurious 'conflicting implementations' error when specializing a type with a compilation error #68830

Open

matthiaskrgr mentioned this pull request May 7, 2024

ICE: should be sized but is not? #124848

Closed

gurry mentioned this pull request May 11, 2024

Fix ICE while casting a type with error #124997

Merged

cushionbadak mentioned this pull request Jun 12, 2024

ICE: SizeSkeleton::compute layout errored in layout.rs #125758

Open

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Fix ICE in `eval_body_using_ecx` #123491

Fix ICE in `eval_body_using_ecx` #123491

gurry commented Apr 5, 2024 •

edited

Loading

rustbot commented Apr 5, 2024

BoxyUwU commented Apr 5, 2024

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

oli-obk commented Apr 15, 2024

bors commented Apr 15, 2024

jieyouxu commented Apr 15, 2024 •

edited

Loading

gurry commented Apr 16, 2024

oli-obk commented Apr 16, 2024

bors commented Apr 16, 2024

Fix ICE in eval_body_using_ecx #123491

Fix ICE in eval_body_using_ecx #123491

Conversation

gurry commented Apr 5, 2024 • edited Loading

rustbot commented Apr 5, 2024

BoxyUwU commented Apr 5, 2024

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

oli-obk commented Apr 15, 2024

bors commented Apr 15, 2024

jieyouxu commented Apr 15, 2024 • edited Loading

gurry commented Apr 16, 2024

oli-obk commented Apr 16, 2024

bors commented Apr 16, 2024

Fix ICE in `eval_body_using_ecx` #123491

Fix ICE in `eval_body_using_ecx` #123491

gurry commented Apr 5, 2024 •

edited

Loading

jieyouxu commented Apr 15, 2024 •

edited

Loading