Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update to LLVM 18.1.3 #123555

Merged
merged 2 commits into from
Apr 7, 2024
Merged

Update to LLVM 18.1.3 #123555

merged 2 commits into from
Apr 7, 2024

Conversation

dianqk
Copy link
Member

@dianqk dianqk commented Apr 6, 2024

Fixes #122805.

This should work on all targets: https://rust.godbolt.org/z/svW8ha31z.

r? @cuviper

@rustbot
Copy link
Collaborator

rustbot commented Apr 6, 2024

⚠️ Warning ⚠️

  • These commits modify submodules.

@rustbot rustbot added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Apr 6, 2024
@cuviper
Copy link
Member

cuviper commented Apr 6, 2024

Looks good!

@bors r+ rollup=never

@bors
Copy link
Collaborator

bors commented Apr 6, 2024

📌 Commit f59517f has been approved by cuviper

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Apr 6, 2024
bors added a commit to rust-lang-ci/rust that referenced this pull request Apr 7, 2024
Update to LLVM 18.1.3

Fixes rust-lang#122805.

This should work on all targets: https://rust.godbolt.org/z/svW8ha31z.

r? `@cuviper`
@bors
Copy link
Collaborator

bors commented Apr 7, 2024

⌛ Testing commit f59517f with merge 76e3145...

@rust-log-analyzer

This comment has been minimized.

@bors
Copy link
Collaborator

bors commented Apr 7, 2024

💔 Test failed - checks-actions

@bors bors added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Apr 7, 2024
@cuviper
Copy link
Member

cuviper commented Apr 7, 2024

Ah, probably should mark that test for min 18.1.3.

@dianqk
Copy link
Member Author

dianqk commented Apr 7, 2024

Ah, probably should mark that test for min 18.1.3.

Ah, Yeah. I have added.

@cuviper
Copy link
Member

cuviper commented Apr 7, 2024

@bors r+

@bors
Copy link
Collaborator

bors commented Apr 7, 2024

📌 Commit 5acfe77 has been approved by cuviper

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Apr 7, 2024
@bors
Copy link
Collaborator

bors commented Apr 7, 2024

⌛ Testing commit 5acfe77 with merge 0e3235f...

@bors
Copy link
Collaborator

bors commented Apr 7, 2024

☀️ Test successful - checks-actions
Approved by: cuviper
Pushing 0e3235f to master...

@bors bors added the merged-by-bors This PR was explicitly merged by bors. label Apr 7, 2024
@bors bors merged commit 0e3235f into rust-lang:master Apr 7, 2024
12 checks passed
@rustbot rustbot added this to the 1.79.0 milestone Apr 7, 2024
@dianqk dianqk deleted the update-llvm-18 branch April 7, 2024 08:48
@dianqk
Copy link
Member Author

dianqk commented Apr 7, 2024

@rustbot label beta-nominated T-compiler

@rustbot rustbot added the beta-nominated Nominated for backporting to the compiler in the beta channel. label Apr 7, 2024
@rustbot rustbot added the T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. label Apr 7, 2024
@rust-timer
Copy link
Collaborator

Finished benchmarking commit (0e3235f): comparison URL.

Overall result: ✅ improvements - no action needed

@rustbot label: -perf-regression

Instruction count

This is a highly reliable metric that was used to determine the overall result at the top of this comment.

mean range count
Regressions ❌
(primary)
- - 0
Regressions ❌
(secondary)
- - 0
Improvements ✅
(primary)
- - 0
Improvements ✅
(secondary)
-0.5% [-0.9%, -0.3%] 8
All ❌✅ (primary) - - 0

Max RSS (memory usage)

Results

This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.

mean range count
Regressions ❌
(primary)
7.1% [7.1%, 7.1%] 1
Regressions ❌
(secondary)
- - 0
Improvements ✅
(primary)
-3.2% [-4.8%, -1.5%] 2
Improvements ✅
(secondary)
-1.7% [-1.7%, -1.7%] 1
All ❌✅ (primary) 0.3% [-4.8%, 7.1%] 3

Cycles

This benchmark run did not return any relevant results for this metric.

Binary size

This benchmark run did not return any relevant results for this metric.

Bootstrap: 668.633s -> 668.306s (-0.05%)
Artifact size: 318.20 MiB -> 318.47 MiB (0.09%)

@apiraino
Copy link
Contributor

apiraino commented Apr 11, 2024

backport voting postponed to next week waiting to see how the MIPS regression evolves. Even if it's a tier 3 regression introduced by this patchset, we're not too eager mergin this yet

Zulip discussion

@dianqk
Copy link
Member Author

dianqk commented Apr 18, 2024

Replaced by #124044.

@rustbot label -beta-nominated

@rustbot rustbot removed the beta-nominated Nominated for backporting to the compiler in the beta channel. label Apr 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
merged-by-bors This PR was explicitly merged by bors. S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Codegen regression in Ipv6Addr [u16; 8] to [u8; 16] conversion
7 participants