-
Notifications
You must be signed in to change notification settings - Fork 13.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update to LLVM 18.1.3 #123555
Update to LLVM 18.1.3 #123555
Conversation
|
Looks good! @bors r+ rollup=never |
Update to LLVM 18.1.3 Fixes rust-lang#122805. This should work on all targets: https://rust.godbolt.org/z/svW8ha31z. r? `@cuviper`
This comment has been minimized.
This comment has been minimized.
💔 Test failed - checks-actions |
Ah, probably should mark that test for min 18.1.3. |
Ah, Yeah. I have added. |
@bors r+ |
☀️ Test successful - checks-actions |
@rustbot label beta-nominated T-compiler |
Finished benchmarking commit (0e3235f): comparison URL. Overall result: ✅ improvements - no action needed@rustbot label: -perf-regression Instruction countThis is a highly reliable metric that was used to determine the overall result at the top of this comment.
Max RSS (memory usage)ResultsThis is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.
CyclesThis benchmark run did not return any relevant results for this metric. Binary sizeThis benchmark run did not return any relevant results for this metric. Bootstrap: 668.633s -> 668.306s (-0.05%) |
backport voting postponed to next week waiting to see how the MIPS regression evolves. Even if it's a tier 3 regression introduced by this patchset, we're not too eager mergin this yet |
Fixes #122805.
This should work on all targets: https://rust.godbolt.org/z/svW8ha31z.
r? @cuviper