Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix OutsideLoop's error suggestion: adding label 'block for if block. #123623

Merged
merged 1 commit into from
May 23, 2024

Conversation

surechen
Copy link
Contributor

@surechen surechen commented Apr 8, 2024

For OutsideLoop we should not suggest add 'block label in if block, or we wiil get another err: block label not supported here.

fixes #123261

@rustbot
Copy link
Collaborator

rustbot commented Apr 8, 2024

r? @estebank

rustbot has assigned @estebank.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. labels Apr 8, 2024
@rust-log-analyzer

This comment has been minimized.

Copy link
Contributor

@estebank estebank left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Left some nitpicks, I need a bit more time to properly review. Thank you for taking the time to address this!

@surechen
Copy link
Contributor Author

Left some nitpicks, I need a bit more time to properly review. Thank you for taking the time to address this!

Okay, thank you very much, your review reply is very prompt, 👍 I'll fix the above problem first.

@rust-log-analyzer

This comment has been minimized.

compiler/rustc_passes/src/loops.rs Outdated Show resolved Hide resolved
compiler/rustc_passes/src/loops.rs Outdated Show resolved Hide resolved
compiler/rustc_passes/src/loops.rs Outdated Show resolved Hide resolved
compiler/rustc_passes/src/loops.rs Outdated Show resolved Hide resolved
compiler/rustc_passes/src/loops.rs Outdated Show resolved Hide resolved
@rust-log-analyzer

This comment has been minimized.

…r we wiil get another err: block label not supported here.

fixes rust-lang#123261
@estebank
Copy link
Contributor

@bors r+

@bors
Copy link
Contributor

bors commented May 23, 2024

📌 Commit 8fde7e3 has been approved by estebank

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels May 23, 2024
bors added a commit to rust-lang-ci/rust that referenced this pull request May 23, 2024
…iaskrgr

Rollup of 8 pull requests

Successful merges:

 - rust-lang#122665 (Add some tests for public-private dependencies.)
 - rust-lang#123623 (Fix OutsideLoop's error suggestion: adding label `'block` for `if` block.)
 - rust-lang#125054 (Handle `ReVar` in `note_and_explain_region`)
 - rust-lang#125156 (Expand `for_loops_over_fallibles` lint to lint on fallibles behind references.)
 - rust-lang#125222 (Migrate `run-make/issue-46239` to `rmake`)
 - rust-lang#125316 (Tweak `Spacing` use)
 - rust-lang#125392 (Wrap Context.ext in AssertUnwindSafe)
 - rust-lang#125417 (self-contained linker: retry linking without `-fuse-ld=lld` on CCs that don't support it)

r? `@ghost`
`@rustbot` modify labels: rollup
@bors bors merged commit 96134e1 into rust-lang:master May 23, 2024
6 checks passed
@rustbot rustbot added this to the 1.80.0 milestone May 23, 2024
rust-timer added a commit to rust-lang-ci/rust that referenced this pull request May 23, 2024
Rollup merge of rust-lang#123623 - surechen:fix_123261, r=estebank

Fix OutsideLoop's error suggestion: adding label `'block` for `if` block.

For OutsideLoop we should not suggest add `'block` label in `if` block, or we wiil get another err: block label not supported here.

fixes rust-lang#123261
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Bad diagnostic in breaking labeled block?
6 participants