Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

correct the handling of bootstrap-cache-path option #123790

Merged
merged 1 commit into from
Apr 11, 2024
Merged

correct the handling of bootstrap-cache-path option #123790

merged 1 commit into from
Apr 11, 2024

Conversation

onur-ozkan
Copy link
Member

This change makes build.bootstrap-cache-path option to be configurable with ./configure script, so it can be used like ./configure --bootstrap-cache-path=demo.

@onur-ozkan
correct the handling of bootstrap-cache-path option
bd47911 
This change makes `build.bootstrap-cache-path` option to be configurable with
`./configure` script, so it can be used like `./configure --bootstrap-cache-path=demo`.

Signed-off-by: onur-ozkan <work@onurozkan.dev>
@rustbot
Copy link
Collaborator

rustbot commented Apr 11, 2024

r? @clubby789

rustbot has assigned @clubby789.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-bootstrap Relevant to the bootstrap subteam: Rust's build system (x.py and src/bootstrap) labels Apr 11, 2024
@rustbot

This comment was marked as off-topic.

Sign in to view
@clubby789
Copy link
Contributor

@bors r+ rollup

@bors
Copy link
Contributor

bors commented Apr 11, 2024

📌 Commit bd47911 has been approved by clubby789

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Apr 11, 2024
@matthiaskrgr matthiaskrgr mentioned this pull request Apr 11, 2024
Merged
bors added a commit to rust-lang-ci/rust that referenced this pull request Apr 11, 2024
@bors
Auto merge of rust-lang#123795 - matthiaskrgr:rollup-deesd9c, r=matth…
df7daa8 
…iaskrgr

Rollup of 4 pull requests

Successful merges:

 - rust-lang#123660 (Make the computation of `coroutine_captures_by_ref_ty` more sophisticated)
 - rust-lang#123738 (Call lower_const_param instead of duplicating the code)
 - rust-lang#123774 (Fix typo MaybeUnit -> MaybeUninit)
 - rust-lang#123790 (correct the handling of `bootstrap-cache-path` option)

r? `@ghost`
`@rustbot` modify labels: rollup
@bors bors merged commit 1620f33 into rust-lang:master Apr 11, 2024
11 checks passed
rust-timer added a commit to rust-lang-ci/rust that referenced this pull request Apr 11, 2024
@rust-timer
Unrolled build for rust-lang#123790
632b60c 
Rollup merge of rust-lang#123790 - onur-ozkan:invalid-config-option, r=clubby789

correct the handling of `bootstrap-cache-path` option

This change makes `build.bootstrap-cache-path` option to be configurable with `./configure` script, so it can be used like `./configure --bootstrap-cache-path=demo`.
@rustbot rustbot added this to the 1.79.0 milestone Apr 11, 2024
@onur-ozkan onur-ozkan deleted the invalid-config-option branch April 11, 2024 18:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@clubby789 clubby789

Labels
S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-bootstrap Relevant to the bootstrap subteam: Rust's build system (x.py and src/bootstrap)
Projects
None yet
Milestone
1.79.0
Development

Successfully merging this pull request may close these issues.
4 participants
@onur-ozkan @rustbot @clubby789 @bors