-
Notifications
You must be signed in to change notification settings - Fork 12.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Rollup of 7 pull requests #123838
Rollup of 7 pull requests #123838
Commits on Apr 11, 2024
-
Set the host library path in run-make v2
When the build is configured with `[rust] rpath = false`, we need to set `LD_LIBRARY_PATH` (or equivalent) to what would have been the `RPATH`, so the compiler can find its own libraries. The old `tools.mk` code has this environment prefixed in the `$(BARE_RUSTC)` variable, so we just need to wire up something similar for run-make v2. This is now set while building each `rmake.rs` itself, as well as in the `rust-make-support` helpers for `rustc` and `rustdoc` commands. This is also available in a `set_host_rpath` function for manual commands, like in the `compiler-builtins` test.
Configuration menu - View commit details
-
Copy full SHA for 8a5409b - Browse repository at this point
Copy the full SHA 8a5409bView commit details -
Make
PlaceRef
hold aPlaceValue
for the non-layout fields (like `……OperandRef` does)
Configuration menu - View commit details
-
Copy full SHA for 89502e5 - Browse repository at this point
Copy the full SHA 89502e5View commit details -
Configuration menu - View commit details
-
Copy full SHA for 3596098 - Browse repository at this point
Copy the full SHA 3596098View commit details -
Configuration menu - View commit details
-
Copy full SHA for d0ae768 - Browse repository at this point
Copy the full SHA d0ae768View commit details -
move QueryKeyStringCache from rustc_middle to rustc_query_impl, where…
… it actually used also allows to drop measureme dep on rustc_middle
Configuration menu - View commit details
-
Copy full SHA for 124837d - Browse repository at this point
Copy the full SHA 124837dView commit details -
Configuration menu - View commit details
-
Copy full SHA for f9ca213 - Browse repository at this point
Copy the full SHA f9ca213View commit details -
Configuration menu - View commit details
-
Copy full SHA for 1170d73 - Browse repository at this point
Copy the full SHA 1170d73View commit details -
Configuration menu - View commit details
-
Copy full SHA for 4ded0b8 - Browse repository at this point
Copy the full SHA 4ded0b8View commit details -
Configuration menu - View commit details
-
Copy full SHA for 5dcd242 - Browse repository at this point
Copy the full SHA 5dcd242View commit details -
Configuration menu - View commit details
-
Copy full SHA for 7e171c7 - Browse repository at this point
Copy the full SHA 7e171c7View commit details
Commits on Apr 12, 2024
-
Rollup merge of rust-lang#123599 - matthiaskrgr:rm, r=cjgillot
remove some things that do not need to be
Configuration menu - View commit details
-
Copy full SHA for 6f78bf2 - Browse repository at this point
Copy the full SHA 6f78bf2View commit details -
Rollup merge of rust-lang#123763 - cuviper:host-rpath-run-make-v2, r=…
…jieyouxu Set the host library path in run-make v2 When the build is configured with `[rust] rpath = false`, we need to set `LD_LIBRARY_PATH` (or equivalent) to what would have been the `RPATH`, so the compiler can find its own libraries. The old `tools.mk` code has this environment prefixed in the `$(BARE_RUSTC)` variable, so we just need to wire up something similar for run-make v2. This is now set while building each `rmake.rs` itself, as well as in the `rust-make-support` helpers for `rustc` and `rustdoc` commands. This is also available in a `set_host_rpath` function for manual commands, like in the `compiler-builtins` test.
Configuration menu - View commit details
-
Copy full SHA for a510cbd - Browse repository at this point
Copy the full SHA a510cbdView commit details -
Rollup merge of rust-lang#123775 - scottmcm:place-val, r=cjgillot
Make `PlaceRef` and `OperandValue::Ref` share a common `PlaceValue` type Both `PlaceRef` and `OperandValue::Ref` need the triple of the backend pointer immediate, the optional backend metadata for DSTs, and the actual alignment of the place (since it can differ from the ABI alignment). This PR introduces a new `PlaceValue` type for those three values, leaving [`PlaceRef`](https://doc.rust-lang.org/nightly/nightly-rustc/rustc_codegen_ssa/mir/place/struct.PlaceRef.html) with the `TyAndLayout` and a `PlaceValue`, just like how [`OperandRef`](https://doc.rust-lang.org/nightly/nightly-rustc/rustc_codegen_ssa/mir/operand/struct.OperandRef.html) is a `TyAndLayout` and an `OperandValue`. This means that various places that use `Ref`s as places can just pass the `PlaceValue` along, like in the below excerpt from the diff: ```diff match operand.val { - OperandValue::Ref(ptr, meta, align) => { - debug_assert_eq!(meta, None); + OperandValue::Ref(source_place_val) => { + debug_assert_eq!(source_place_val.llextra, None); debug_assert!(matches!(operand_kind, OperandValueKind::Ref)); - let fake_place = PlaceRef::new_sized_aligned(ptr, cast, align); + let fake_place = PlaceRef { val: source_place_val, layout: cast }; Some(bx.load_operand(fake_place).val) } ``` There's more refactoring that I'd like to do after this, but I wanted to stop the PR here where it's hopefully easy (albeit probably not quick) to review since I tried to keep every change line-by-line clear. (Most are just adding `.val` to get to a field.) You can also go commit-at-a-time if you'd like. Each passed tidy and the codegen tests on my machine (though I didn't run the cg_gcc ones).
Configuration menu - View commit details
-
Copy full SHA for f4f6441 - Browse repository at this point
Copy the full SHA f4f6441View commit details -
Rollup merge of rust-lang#123789 - klensy:rq, r=cjgillot
move QueryKeyStringCache from rustc_middle to rustc_query_impl, where it actually used Also allows to drop measureme dep on rustc_middle.
Configuration menu - View commit details
-
Copy full SHA for 41a294d - Browse repository at this point
Copy the full SHA 41a294dView commit details -
Rollup merge of rust-lang#123826 - kornelski:one-in-a-quintillion, r=…
…Amanieu Move rare overflow error to a cold function `scoped.spawn()` generates unnecessary inlined panic-formatting code for a branch that will never be taken.
Configuration menu - View commit details
-
Copy full SHA for 3758e2f - Browse repository at this point
Copy the full SHA 3758e2fView commit details -
Rollup merge of rust-lang#123827 - petrochenkov:searchdirs, r=Nadrieril
linker: Avoid some allocations in search directory iteration This is more a cleanup than actual optimization.
Configuration menu - View commit details
-
Copy full SHA for 7f11183 - Browse repository at this point
Copy the full SHA 7f11183View commit details -
Rollup merge of rust-lang#123829 - saethlin:fix-revisions, r=jieyouxu
Fix revisions syntax in cfg(ub_checks) test `//@ revisions YES NO` doesn't do anything without the `:`. Thanks for pointing this out to me. r? jieyouxu
Configuration menu - View commit details
-
Copy full SHA for 2679ea0 - Browse repository at this point
Copy the full SHA 2679ea0View commit details