Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update cargo #123874

Merged
merged 1 commit into from
Apr 13, 2024
Merged

Update cargo #123874

merged 1 commit into from
Apr 13, 2024

Conversation

weihanglo
Copy link
Member

8 commits in 74fd5bc730b828dbc956335b229ac34ba47f7ef7..48eca1b164695022295ce466b64b44e4e0228b08
2024-04-10 18:40:49 +0000 to 2024-04-12 21:16:36 +0000

r? ghost

@rustbot rustbot added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Apr 12, 2024
@rustbot
Copy link
Collaborator

rustbot commented Apr 12, 2024

Some changes occurred in src/tools/cargo

cc @ehuss

@weihanglo
Copy link
Member Author

@bors r+ rollup=never p=1

@bors
Copy link
Contributor

bors commented Apr 12, 2024

📌 Commit 62e9855 has been approved by weihanglo

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Apr 12, 2024
bors added a commit to rust-lang-ci/rust that referenced this pull request Apr 13, 2024
Update cargo

8 commits in 74fd5bc730b828dbc956335b229ac34ba47f7ef7..48eca1b164695022295ce466b64b44e4e0228b08
2024-04-10 18:40:49 +0000 to 2024-04-12 21:16:36 +0000
- test: Remove add/remove death tests (rust-lang/cargo#13750)
- feat(resolve): Fallback to 'rustc -V' for MSRV resolving (rust-lang/cargo#13743)
- feat(cli): Add --ignore-rust-version to update/generate-lockfile (rust-lang/cargo#13742)
- `cargo package -p no-exist` emitt  error when the -p `package` not found (rust-lang/cargo#13735)
- fix(help): Generalize --ignore-rust-version (rust-lang/cargo#13741)
- test: don't compress test registry crates (rust-lang/cargo#13744)
- feat(reslve): Respect '--ignore-rust-version' (rust-lang/cargo#13738)
- refactor: Remove `rust_2024_compatibility` lint group (rust-lang/cargo#13740)

r? ghost
@bors
Copy link
Contributor

bors commented Apr 13, 2024

⌛ Testing commit 62e9855 with merge 0cc1879...

@rust-log-analyzer
Copy link
Collaborator

The job i686-msvc failed! Check out the build log: (web) (plain)

Click to see the possible cause of the failure (guessed by this bot)
error: make failed
status: exit code: 2
command: "make"
--- stdout -------------------------------
make[1]: Entering directory '/c/a/rust/rust/tests/run-make/pdb-buildinfo-cl-cmd'
C:\a\rust\rust\build\i686-pc-windows-msvc\stage2\bin\rustc.exe main.rs -g --crate-name my_crate_name --crate-type bin -C metadata=dc9ef878b0a48666 --out-dir /c/a/rust/rust/build/i686-pc-windows-msvc/test/run-make/pdb-buildinfo-cl-cmd/pdb-buildinfo-cl-cmd
cat '/c/a/rust/rust/build/i686-pc-windows-msvc/test/run-make/pdb-buildinfo-cl-cmd/pdb-buildinfo-cl-cmd/my_crate_name.pdb' | grep -F 'C:\a\rust\rust\build\i686-pc-windows-msvc\stage2\bin\rustc.exe'
Binary file (standard input) matches
cat '/c/a/rust/rust/build/i686-pc-windows-msvc/test/run-make/pdb-buildinfo-cl-cmd/pdb-buildinfo-cl-cmd/my_crate_name.pdb' | grep -f 'stringlist.txt'
make[1]: Leaving directory '/c/a/rust/rust/tests/run-make/pdb-buildinfo-cl-cmd'
--- stderr -------------------------------
make[1]: *** [Makefile:15: all] Error 1
------------------------------------------

---
test result: FAILED. 246 passed; 1 failed; 105 ignored; 0 measured; 0 filtered out; finished in 75.50s

Some tests failed in compiletest suite=run-make mode=run-make host=i686-pc-windows-msvc target=i686-pc-windows-msvc
Build completed unsuccessfully in 1:23:12
make: *** [Makefile:103: ci-msvc-ps1] Error 1
  network time: Sat, 13 Apr 2024 02:07:34 GMT
##[error]Process completed with exit code 2.
Post job cleanup.
[command]"C:\Program Files\Git\bin\git.exe" version

@bors
Copy link
Contributor

bors commented Apr 13, 2024

💔 Test failed - checks-actions

@bors bors added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Apr 13, 2024
@weihanglo
Copy link
Member Author

Seems irrelevant to cargo

@bors retry

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Apr 13, 2024
@bors
Copy link
Contributor

bors commented Apr 13, 2024

⌛ Testing commit 62e9855 with merge 6cfd809...

@bors
Copy link
Contributor

bors commented Apr 13, 2024

☀️ Test successful - checks-actions
Approved by: weihanglo
Pushing 6cfd809 to master...

@bors bors added the merged-by-bors This PR was explicitly merged by bors. label Apr 13, 2024
@bors bors merged commit 6cfd809 into rust-lang:master Apr 13, 2024
12 checks passed
@rustbot rustbot added this to the 1.79.0 milestone Apr 13, 2024
@rust-timer
Copy link
Collaborator

Finished benchmarking commit (6cfd809): comparison URL.

Overall result: no relevant changes - no action needed

@rustbot label: -perf-regression

Instruction count

This benchmark run did not return any relevant results for this metric.

Max RSS (memory usage)

Results

This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.

mean range count
Regressions ❌
(primary)
1.2% [1.2%, 1.2%] 1
Regressions ❌
(secondary)
- - 0
Improvements ✅
(primary)
- - 0
Improvements ✅
(secondary)
- - 0
All ❌✅ (primary) 1.2% [1.2%, 1.2%] 1

Cycles

This benchmark run did not return any relevant results for this metric.

Binary size

This benchmark run did not return any relevant results for this metric.

Bootstrap: 677.972s -> 674.576s (-0.50%)
Artifact size: 316.06 MiB -> 316.03 MiB (-0.01%)

@weihanglo weihanglo deleted the update-cargo branch April 13, 2024 11:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
merged-by-bors This PR was explicitly merged by bors. S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants