weak lang items are not allowed to be #[track_caller] #124067
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
r? @davidtwco rustbot has assigned @davidtwco. Use |
rustbot
added
S-waiting-on-review
|
Some changes occurred to MIR optimizations cc @rust-lang/wg-mir-opt |
This comment has been minimized.
This comment has been minimized.
RalfJung
force-pushed
the
weak-lang-items
branch
from
8cdd6b7
to
8b35be7
Compare
davidtwco
approved these changes
Apr 23, 2024
|
@bors r+ rollup |
bors
added
S-waiting-on-bors
bors
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Apr 23, 2024
…iaskrgr Rollup of 5 pull requests Successful merges: - rust-lang#123050 (panic_str only exists for the migration to 2021 panic macros) - rust-lang#124067 (weak lang items are not allowed to be #[track_caller]) - rust-lang#124099 (Disallow ambiguous attributes on expressions) - rust-lang#124284 (parser: remove unused(no reads) max_angle_bracket_count field) - rust-lang#124288 (remove `push_trait_bound_inner`) r? `@ghost` `@rustbot` modify labels: rollup
rust-timer
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Apr 23, 2024
Rollup merge of rust-lang#124067 - RalfJung:weak-lang-items, r=davidtwco weak lang items are not allowed to be #[track_caller] For instance the panic handler will be called via this import ```rust extern "Rust" { #[lang = "panic_impl"] fn panic_impl(pi: &PanicInfo<'_>) -> !; } ``` A `#[track_caller]` would add an extra argument and thus make this the wrong signature. The 2nd commit is a consistency rename; based on the docs [here](https://doc.rust-lang.org/unstable-book/language-features/lang-items.html) and [here](https://rustc-dev-guide.rust-lang.org/lang-items.html) I figured "lang item" is more widely used. (In the compiler output, "lang item" and "language item" seem to be pretty even.)
riking
added a commit
to riking/rust
that referenced
this pull request
May 8, 2024
Only one of the two mentions of the attribute were updated.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For instance the panic handler will be called via this import
A
#[track_caller]would add an extra argument and thus make this the wrong signature.The 2nd commit is a consistency rename; based on the docs here and here I figured "lang item" is more widely used. (In the compiler output, "lang item" and "language item" seem to be pretty even.)