Skip to content

Triagebot: Rename macos ping group to apple #124146

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
May 6, 2024
Merged

Triagebot: Rename macos ping group to apple #124146

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
b90bcd6
Make autolabelling for macOS slightly better
madsmtm Apr 19, 2024
e64cbc4
Rename `macos` ping group to `apple`
madsmtm Apr 19, 2024
dc153f8
Change the label for the Apple ping group to the new O-apple
madsmtm May 5, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
18 changes: 13 additions & 5 deletions triagebot.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -106,12 +106,18 @@ resolved/implemented on Fuchsia. Could one of you weigh in?
"""
label = "O-fuchsia"

[ping.macos]
[ping.apple]
alias = ["macos", "ios", "tvos", "watchos", "visionos"]
message = """\
Hey MacOS Group! This issue or PR could use some MacOS-specific guidance. Could one
of you weigh in? Thanks <3
Hey Apple notification group! This issue or PR could use some Apple-specific
guidance. Could one of you weigh in? Thanks <3

(In case it's useful, here are some [instructions] for tackling these sorts of
issues).

[instructions]: https://rustc-dev-guide.rust-lang.org/notification-groups/apple.html
"""
label = "O-macos"
label = "O-apple"

[prioritize]
label = "I-prioritize"
Expand Down Expand Up @@ -227,7 +233,9 @@ trigger_files = [

[autolabel."O-macos"]
trigger_files = [
"library/std/src/os/macos"
"library/std/src/os/macos",
"library/std/src/sys/pal/unix/thread_parking/darwin.rs",
"compiler/rustc_target/src/spec/base/apple",
]

[autolabel."O-netbsd"]
Expand Down