Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for run-make-support unit tests to be run with bootstrap #124321

Merged
merged 1 commit into from
Apr 26, 2024

Conversation

JoverZhang
Copy link
Contributor

The run-make-support library needs to run its unit tests to ensure it is correct.

Close #124267

@rustbot
Copy link
Collaborator

rustbot commented Apr 24, 2024

Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @clubby789 (or someone else) some time within the next two weeks.

Please see the contribution instructions for more information. Namely, in order to ensure the minimum review times lag, PR authors and assigned reviewers should ensure that the review label (S-waiting-on-review and S-waiting-on-author) stays updated, invoking these commands when appropriate:

  • @rustbot author: the review is finished, PR author should check the comments and take action accordingly
  • @rustbot review: the author is ready for a review, this PR will be queued again in the reviewer's queue

@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-bootstrap Relevant to the bootstrap subteam: Rust's build system (x.py and src/bootstrap) labels Apr 24, 2024
@JoverZhang JoverZhang force-pushed the run-make-support-tests branch from 9821098 to 93bfb09 Compare April 24, 2024 13:21
@JoverZhang JoverZhang requested a review from filnet April 24, 2024 13:22
@onur-ozkan onur-ozkan changed the title Add support for run-make-support unit tests to be run with bootstrap command Add support for run-make-support unit tests to be run with bootstrap Apr 25, 2024
@onur-ozkan onur-ozkan added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Apr 25, 2024
@onur-ozkan onur-ozkan assigned onur-ozkan and unassigned clubby789 Apr 25, 2024
@JoverZhang JoverZhang force-pushed the run-make-support-tests branch from a84a5f7 to effa6a1 Compare April 26, 2024 01:02
@JoverZhang JoverZhang requested a review from onur-ozkan April 26, 2024 01:04
@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Apr 26, 2024
@onur-ozkan onur-ozkan added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Apr 26, 2024
…command

Co-authored-by: Onur Özkan <onurozkan.dev@outlook.com>
@JoverZhang JoverZhang force-pushed the run-make-support-tests branch from effa6a1 to c028782 Compare April 26, 2024 07:33
@JoverZhang JoverZhang requested a review from onur-ozkan April 26, 2024 07:34
@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Apr 26, 2024
@onur-ozkan
Copy link
Member

Thank you!

@bors r+

@bors
Copy link
Contributor

bors commented Apr 26, 2024

📌 Commit c028782 has been approved by onur-ozkan

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Apr 26, 2024
@bors
Copy link
Contributor

bors commented Apr 26, 2024

⌛ Testing commit c028782 with merge 9adafa7...

@bors
Copy link
Contributor

bors commented Apr 26, 2024

☀️ Test successful - checks-actions
Approved by: onur-ozkan
Pushing 9adafa7 to master...

1 similar comment
@bors
Copy link
Contributor

bors commented Apr 26, 2024

☀️ Test successful - checks-actions
Approved by: onur-ozkan
Pushing 9adafa7 to master...

@bors bors added the merged-by-bors This PR was explicitly merged by bors. label Apr 26, 2024
@bors bors merged commit 9adafa7 into rust-lang:master Apr 26, 2024
11 checks passed
@rustbot rustbot added this to the 1.79.0 milestone Apr 26, 2024
@rust-timer
Copy link
Collaborator

Finished benchmarking commit (9adafa7): comparison URL.

Overall result: no relevant changes - no action needed

@rustbot label: -perf-regression

Instruction count

This benchmark run did not return any relevant results for this metric.

Max RSS (memory usage)

This benchmark run did not return any relevant results for this metric.

Cycles

Results

This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.

mean range count
Regressions ❌
(primary)
1.1% [1.1%, 1.1%] 1
Regressions ❌
(secondary)
- - 0
Improvements ✅
(primary)
- - 0
Improvements ✅
(secondary)
- - 0
All ❌✅ (primary) 1.1% [1.1%, 1.1%] 1

Binary size

This benchmark run did not return any relevant results for this metric.

Bootstrap: 670.891s -> 671.528s (0.09%)
Artifact size: 315.98 MiB -> 316.01 MiB (0.01%)

@JoverZhang JoverZhang deleted the run-make-support-tests branch May 4, 2024 06:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
merged-by-bors This PR was explicitly merged by bors. S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-bootstrap Relevant to the bootstrap subteam: Rust's build system (x.py and src/bootstrap)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Allow run-make-support unit tests to be run with bootstrap command x test src/tools/run-make-support
7 participants