Remove special-casing for SimplifiedType for next solver
#124379
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rustbot
added
S-waiting-on-review
|
Some changes occurred to the core trait solver cc @rust-lang/initiative-trait-system-refactor |
This comment has been minimized.
This comment has been minimized.
lcnr
reviewed
Apr 25, 2024
Comment on lines
-166
to
-167
| // Note that we're using `TreatParams::ForLookup` to query `non_blanket_impls` while using | ||
| // `TreatParams::AsCandidateKey` while actually adding them. |
There was a problem hiding this comment.
these two lines are still important
compiler-errors
force-pushed
the
remove-new-solver-lookup-behavior
branch
from
1555214
to
f2518cd
Compare
|
Some changes occurred to the core trait solver cc @rust-lang/initiative-trait-system-refactor |
|
@bors r=lcnr |
bors
added
S-waiting-on-bors
bors
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Apr 25, 2024
…okup-behavior, r=lcnr Remove special-casing for `SimplifiedType` for next solver It's unnecessary due to the way that we fully normalize the self type before assembly begins. r? lcnr
|
The job Click to see the possible cause of the failure (guessed by this bot) |
|
💔 Test failed - checks-actions |
bors
added
S-waiting-on-review
|
@bors retry |
bors
added
S-waiting-on-bors
bors
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Apr 26, 2024
…mpiler-errors Rollup of 4 pull requests Successful merges: - rust-lang#124076 (Stablise io_error_downcast) - rust-lang#124378 (Keep the LIB env var in the compiler-builtins test) - rust-lang#124379 (Remove special-casing for `SimplifiedType` for next solver) - rust-lang#124381 (Renamed `DerivedObligation` to `WellFormedDeriveObligation`) r? `@ghost` `@rustbot` modify labels: rollup
rust-timer
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Apr 26, 2024
Rollup merge of rust-lang#124379 - compiler-errors:remove-new-solver-lookup-behavior, r=lcnr Remove special-casing for `SimplifiedType` for next solver It's unnecessary due to the way that we fully normalize the self type before assembly begins. r? lcnr
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It's unnecessary due to the way that we fully normalize the self type before assembly begins.
r? lcnr