rustc_builtin_macros cleanups
#124391
Merged
rustc_builtin_macros cleanups
#124391
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
For code clarity.
Making this a proper struct, and giving its fields names, makes things easier to understand.
These functions are only used in `rustc_builtin_macros`, so it makes sense for them to live there. This allows them to be changed from `pub` to `pub(crate)`.
rustbot
added
S-waiting-on-review
|
Some changes occurred in src/tools/rustfmt cc @rust-lang/rustfmt |
ytmimi
reviewed
Apr 26, 2024
nnethercote
force-pushed
the
builtin_macros-cleanups
branch
from
7cbc3ef
to
30d6f63
Compare
|
@bors r+ rollup |
bors
added
S-waiting-on-bors
matthiaskrgr
added a commit
to matthiaskrgr/rust
that referenced
this pull request
Apr 26, 2024
…s, r=fee1-dead `rustc_builtin_macros` cleanups Some improvements I found while looking over this code. r? `@fee1-dead`
bors
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Apr 26, 2024
…iaskrgr Rollup of 5 pull requests Successful merges: - rust-lang#124341 (resolve: Remove two cases of misleading macro call visiting) - rust-lang#124383 (Port run-make `--print=native-static-libs` to rmake.rs) - rust-lang#124391 (`rustc_builtin_macros` cleanups) - rust-lang#124408 (crashes: add more tests) - rust-lang#124410 (PathBuf: replace transmuting by accessor functions) r? `@ghost` `@rustbot` modify labels: rollup
bors
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Apr 27, 2024
Rollup of 5 pull requests Successful merges: - rust-lang#124341 (resolve: Remove two cases of misleading macro call visiting) - rust-lang#124383 (Port run-make `--print=native-static-libs` to rmake.rs) - rust-lang#124391 (`rustc_builtin_macros` cleanups) - rust-lang#124408 (crashes: add more tests) - rust-lang#124410 (PathBuf: replace transmuting by accessor functions) r? `@ghost` `@rustbot` modify labels: rollup
rust-timer
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Apr 27, 2024
Rollup merge of rust-lang#124391 - nnethercote:builtin_macros-cleanups, r=fee1-dead `rustc_builtin_macros` cleanups Some improvements I found while looking over this code. r? ``@fee1-dead``
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some improvements I found while looking over this code.
r? @fee1-dead