Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use probes more aggressively in new solver #124415

Merged
merged 3 commits into from
Apr 29, 2024
Merged

Use probes more aggressively in new solver #124415

merged 3 commits into from
Apr 29, 2024

Conversation

compiler-errors
Copy link
Member

....so that we have the right candidate information when assembling trait and normalizes-to goals.

Also gets rid of misc probes.

r? lcnr

@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. WG-trait-system-refactor The Rustc Trait System Refactor Initiative (-Znext-solver) labels Apr 26, 2024
@rustbot
Copy link
Collaborator

rustbot commented Apr 26, 2024

Some changes occurred to the core trait solver

cc @rust-lang/initiative-trait-system-refactor

@rust-log-analyzer

This comment has been minimized.

Sign in to view
lcnr
lcnr reviewed Apr 27, 2024
View reviewed changes
Copy link
Contributor

@lcnr lcnr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

happy with this PR, you have to fix how analyse.rs collects candidates though, maybe rely on #124444

@compiler-errors compiler-errors force-pushed the candidates branch 2 times, most recently from 68734ca to 2f44e5c Compare April 28, 2024 19:45
@rust-log-analyzer

This comment has been minimized.

Sign in to view
@lcnr
Copy link
Contributor

lcnr commented Apr 29, 2024

r=me after removing the "lol" comment :3

@lcnr
Copy link
Contributor

lcnr commented Apr 29, 2024

@bors + rollup=always

@compiler-errors
Copy link
Member Author

@bors r=lcnr rollup=always

@bors
Copy link
Collaborator

bors commented Apr 29, 2024

📌 Commit 2eb7c81 has been approved by lcnr

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Apr 29, 2024
@jieyouxu jieyouxu mentioned this pull request Apr 29, 2024
Merged
@compiler-errors compiler-errors mentioned this pull request Apr 29, 2024
Merged
@bors bors merged commit 4355749 into rust-lang:master Apr 29, 2024
10 checks passed
@rustbot rustbot added this to the 1.80.0 milestone Apr 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lqd lqd lqd left review comments

@lcnr lcnr lcnr left review comments

Assignees

@lcnr lcnr

Labels
S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. WG-trait-system-refactor The Rustc Trait System Refactor Initiative (-Znext-solver)
Projects
None yet
Milestone
1.80.0
Development

Successfully merging this pull request may close these issues.
6 participants
@compiler-errors @rustbot @rust-log-analyzer @lcnr @bors @lqd