-
Notifications
You must be signed in to change notification settings - Fork 12.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Relax A: Clone
bound for rc::Weak::into_raw_and_alloc
#124432
Relax A: Clone
bound for rc::Weak::into_raw_and_alloc
#124432
Conversation
r? @Nilstrieb rustbot has assigned @Nilstrieb. Use |
This comment has been minimized.
This comment has been minimized.
7993163
to
255a1e9
Compare
This brings an unstable API in line with the other variants of it, being an obvious improvement relaxing a bound that didn't make sense in the first place, so I'm approving this without libs-api input. |
☀️ Test successful - checks-actions |
Finished benchmarking commit (61a1dbd): comparison URL. Overall result: no relevant changes - no action needed@rustbot label: -perf-regression Instruction countThis benchmark run did not return any relevant results for this metric. Max RSS (memory usage)ResultsThis is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.
CyclesResultsThis is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.
Binary sizeThis benchmark run did not return any relevant results for this metric. Bootstrap: 674.042s -> 672.072s (-0.29%) |
Makes this method to behave the same way as
Box::into_raw_with_allocator
andVec::into_raw_parts_with_alloc
.I have also noticed the inconsistent presence and naming, should probably be addressed in the future.