handle the targets that are missing in stage0 #124461
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: onur-ozkan <work@onurozkan.dev>
|
rustbot has assigned @Mark-Simulacrum. Use |
rustbot
added
S-waiting-on-review
|
r? @pietroalbini It would be nice to add a check somewhere that errors out if one of the targets in |
bors
added
S-waiting-on-bors
|
I still think parsing the target list in rustc_target is a better idea, but 🤷 |
bors
added a commit
to rust-lang-ci/rust
that referenced
this pull request
May 3, 2024
…iaskrgr Rollup of 6 pull requests Successful merges: - rust-lang#124461 (handle the targets that are missing in stage0) - rust-lang#124492 (Generalize `adjust_from_tcx` for `Allocation`) - rust-lang#124588 (Use `ObligationCtxt` in favor of `TraitEngine` in many more places) - rust-lang#124612 (Add support for inputing via stdin with run-make-support) - rust-lang#124613 (Allow fmt to run on rmake.rs test files) - rust-lang#124649 (Fix HorizonOS build broken by rust-lang#124210) r? `@ghost` `@rustbot` modify labels: rollup
rust-timer
added a commit
to rust-lang-ci/rust
that referenced
this pull request
May 3, 2024
Rollup merge of rust-lang#124461 - onur-ozkan:followup-123546, r=pietroalbini handle the targets that are missing in stage0 During sanity checks, we search for target names to determine if they exist in the compiler's built-in target list (`rustc --print target-list`). While a target name may be present in the stage2 compiler, it might not yet be included in stage0. This PR handles that difference. Follow-up of rust-lang#123546
bors
added a commit
to rust-lang-ci/rust
that referenced
this pull request
May 19, 2024
…albini keep the `STAGE0_MISSING_TARGETS` list updated Implements rust-lang#124461 (comment). r? pietroalbini
RalfJung
pushed a commit
to RalfJung/miri
that referenced
this pull request
May 22, 2024
keep the `STAGE0_MISSING_TARGETS` list updated Implements rust-lang/rust#124461 (comment). r? pietroalbini
flip1995
pushed a commit
to flip1995/rust-clippy
that referenced
this pull request
May 24, 2024
keep the `STAGE0_MISSING_TARGETS` list updated Implements rust-lang/rust#124461 (comment). r? pietroalbini
bors
added a commit
to rust-lang/rust-analyzer
that referenced
this pull request
Jun 20, 2024
keep the `STAGE0_MISSING_TARGETS` list updated Implements rust-lang/rust#124461 (comment). r? pietroalbini
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
During sanity checks, we search for target names to determine if they exist in the compiler's built-in target list (
rustc --print target-list). While a target name may be present in the stage2 compiler, it might not yet be included in stage0. This PR handles that difference.Follow-up of #123546