parser: suggest quotes only for ident attribute values

[ohno418]

When encountering code like:

#[cfg(key = ["a", "b"])]
fn main() {}

the parser incorrectly suggests:

error: expected unsuffixed literal, found `[`
 --> ../pg/src/main.rs:1:13
  |
1 | #[cfg(key = ["foo", "bar"])]
  |             ^
  |
help: surround the identifier with quotation marks to parse it as a string
  |
1 | #[cfg(key =" "["foo", "bar"])]
  |            + +

error: aborting due to 1 previous error

This commit modifies the parser to check if an attribute value is an ident before suggesting.

[rustbot]

r? @nnethercote

rustbot has assigned @nnethercote.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

[ohno418]

r? diagnostics

[compiler-errors]

This needs a test

@rustbot author

[ohno418]

Added a test.

@compiler-errors
Could you take another look at this?
r? @compiler-errors

[rustbot]

Could not assign reviewer from: compiler-errors.
User(s) compiler-errors are either the PR author, already assigned, or on vacation, and there are no other candidates.
Use r? to specify someone else to assign.

[bors]

☔ The latest upstream changes (presumably #124972) made this pull request unmergeable. Please resolve the merge conflicts.

[ohno418]

Closing as this has been fixed by 0ad3c5d.