-
Notifications
You must be signed in to change notification settings - Fork 12.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improve check-cfg CLI errors with more structured diagnostics #124679
Conversation
r? @nnethercote rustbot has assigned @nnethercote. Use |
These commits modify the If this was unintentional then you should revert the changes before this PR is merged. |
☔ The latest upstream changes (presumably #124345) made this pull request unmergeable. Please resolve the merge conflicts. |
81830c5
to
f39d5b1
Compare
r=me after rebasing. |
f39d5b1
to
228496e
Compare
@nnethercote I believe I did two days ago. At least rebasing locally doesn't give any conflict. But anyway, rebased and push. |
Ah, yep. @bors r+ |
☀️ Test successful - checks-actions |
Finished benchmarking commit (69f53f5): comparison URL. Overall result: no relevant changes - no action needed@rustbot label: -perf-regression Instruction countThis benchmark run did not return any relevant results for this metric. Max RSS (memory usage)This benchmark run did not return any relevant results for this metric. CyclesThis benchmark run did not return any relevant results for this metric. Binary sizeThis benchmark run did not return any relevant results for this metric. Bootstrap: 674.088s -> 674.594s (0.08%) |
This PR improve check-cfg CLI errors with more structured diagnostics.
In particular it now shows the statement where the error occurred, what kind lit it is, as well as pointing users to the doc for more details.
@rustbot label +F-check-cfg