Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add std::io::IoSlice::as_slice method #124680

Closed
wants to merge 1 commit into from
Closed
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
28 changes: 28 additions & 0 deletions library/std/src/io/mod.rs
Original file line number Diff line number Diff line change
Expand Up @@ -1385,6 +1385,34 @@
IoSlice(sys::io::IoSlice::new(buf))
}

/// Returns a copy of the wrapped slice.
///
/// The lifetime of the slice is not bound to the `IoSlice` itself, instead it references the
/// wrapped slice itself. This is unlike the slice which can be obtained from the [`Deref`]
/// implementation, its lifetime is tied to the specific `IoSlice`. This makes `as_slice`
/// suitable for changing the length of the slice in-place.
///
/// # Examples
///
/// ```
/// #![feature(io_slice_as_slice)]
///
/// use std::io::IoSlice;
///
/// let data = [0, 1, 2, 3, 4];
/// let mut buf = IoSlice::new(&data);
///
/// // Discard the first and last bytes
/// buf = IoSlice::new(buf.as_slice()[1..4]);

Check failure on line 1406 in library/std/src/io/mod.rs

View workflow job for this annotation

GitHub Actions / PR - mingw-check

mismatched types
/// assert_eq!(buf.as_slice(), [1, 2, 3].as_ref());
/// ```
#[unstable(feature = "io_slice_as_slice", issue = "124659")]
#[must_use]
#[inline]
pub fn as_slice(&self) -> &'a [u8] {
self.0.as_slice()
}

/// Advance the internal cursor of the slice.
///
/// Also see [`IoSlice::advance_slices`] to advance the cursors of multiple
Expand Down
2 changes: 1 addition & 1 deletion library/std/src/sys/pal/solid/io.rs
Original file line number Diff line number Diff line change
Expand Up @@ -33,7 +33,7 @@ impl<'a> IoSlice<'a> {
}

#[inline]
pub fn as_slice(&self) -> &[u8] {
pub fn as_slice(&self) -> &'a [u8] {
unsafe { slice::from_raw_parts(self.vec.iov_base as *mut u8, self.vec.iov_len) }
}
}
Expand Down
2 changes: 1 addition & 1 deletion library/std/src/sys/pal/unix/io.rs
Original file line number Diff line number Diff line change
Expand Up @@ -33,7 +33,7 @@ impl<'a> IoSlice<'a> {
}

#[inline]
pub fn as_slice(&self) -> &[u8] {
pub fn as_slice(&self) -> &'a [u8] {
unsafe { slice::from_raw_parts(self.vec.iov_base as *mut u8, self.vec.iov_len) }
}
}
Expand Down
2 changes: 1 addition & 1 deletion library/std/src/sys/pal/unsupported/io.rs
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,7 @@ impl<'a> IoSlice<'a> {
}

#[inline]
pub fn as_slice(&self) -> &[u8] {
pub fn as_slice(&self) -> &'a [u8] {
self.0
}
}
Expand Down
2 changes: 1 addition & 1 deletion library/std/src/sys/pal/wasi/io.rs
Original file line number Diff line number Diff line change
Expand Up @@ -30,7 +30,7 @@ impl<'a> IoSlice<'a> {
}

#[inline]
pub fn as_slice(&self) -> &[u8] {
pub fn as_slice(&self) -> &'a [u8] {
unsafe { slice::from_raw_parts(self.vec.buf as *const u8, self.vec.buf_len) }
}
}
Expand Down
2 changes: 1 addition & 1 deletion library/std/src/sys/pal/windows/io.rs
Original file line number Diff line number Diff line change
Expand Up @@ -35,7 +35,7 @@ impl<'a> IoSlice<'a> {
}

#[inline]
pub fn as_slice(&self) -> &[u8] {
pub fn as_slice(&self) -> &'a [u8] {
unsafe { slice::from_raw_parts(self.vec.buf, self.vec.len as usize) }
}
}
Expand Down
Loading