-
Notifications
You must be signed in to change notification settings - Fork 12.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Rollup of 6 pull requests #124697
Rollup of 6 pull requests #124697
Commits on Apr 2, 2024
-
Configuration menu - View commit details
-
Copy full SHA for e7b5730 - Browse repository at this point
Copy the full SHA e7b5730View commit details
Commits on Apr 3, 2024
-
Configuration menu - View commit details
-
Copy full SHA for 061d873 - Browse repository at this point
Copy the full SHA 061d873View commit details
Commits on Apr 8, 2024
-
Configuration menu - View commit details
-
Copy full SHA for 37c1758 - Browse repository at this point
Copy the full SHA 37c1758View commit details
Commits on Apr 28, 2024
-
lldb-formatters: Use StdSliceSyntheticProvider for &str
Vladimir Makayev committedApr 28, 2024 Configuration menu - View commit details
-
Copy full SHA for 3e82257 - Browse repository at this point
Copy the full SHA 3e82257View commit details
Commits on May 2, 2024
-
Configuration menu - View commit details
-
Copy full SHA for a56fd37 - Browse repository at this point
Copy the full SHA a56fd37View commit details
Commits on May 3, 2024
-
Configuration menu - View commit details
-
Copy full SHA for 351658a - Browse repository at this point
Copy the full SHA 351658aView commit details -
Ensure miri only uses fallback bodies that have manually been vetted …
…to preserve all UB that the native intrinsic would have
Configuration menu - View commit details
-
Copy full SHA for 821d23b - Browse repository at this point
Copy the full SHA 821d23bView commit details -
Set non-leaf frame pointers on Fuchsia targets
David Koloski committedMay 3, 2024 Configuration menu - View commit details
-
Copy full SHA for 0637709 - Browse repository at this point
Copy the full SHA 0637709View commit details
Commits on May 4, 2024
-
Configuration menu - View commit details
-
Copy full SHA for e404e7a - Browse repository at this point
Copy the full SHA e404e7aView commit details -
Configuration menu - View commit details
-
Copy full SHA for 4e97c6c - Browse repository at this point
Copy the full SHA 4e97c6cView commit details -
Rollup merge of rust-lang#123356 - joboet:set_current_size, r=ChrisDe…
…nton Reduce code size of `thread::set_current` rust-lang#123265 introduced a rather large binary size regression, because it added an `unwrap()` call on a `Result<(), Thread>`, which in turn pulled its rather heavy `Debug` implementation. This PR fixes this by readding the `rtassert!` that was removed.
Configuration menu - View commit details
-
Copy full SHA for d596b1e - Browse repository at this point
Copy the full SHA d596b1eView commit details -
Rollup merge of rust-lang#124159 - joboet:move_pal_thread_parking, r=…
…ChrisDenton Move thread parking to `sys::sync` Part of rust-lang#117276. I'll leave the platform-specific API abstractions in `sys::pal`, as per the initial proposal. I'm not entirely sure whether we'll want to keep it that way, but that remains to be seen. r? `@ChrisDenton` (if you have time)
Configuration menu - View commit details
-
Copy full SHA for 5ec2ad5 - Browse repository at this point
Copy the full SHA 5ec2ad5View commit details -
Rollup merge of rust-lang#124293 - oli-obk:miri_intrinsic_fallback_bo…
…dy, r=RalfJung Let miri and const eval execute intrinsics' fallback bodies fixes rust-lang/miri#3397 r? `@RalfJung`
Configuration menu - View commit details
-
Copy full SHA for d577d04 - Browse repository at this point
Copy the full SHA d577d04View commit details -
Rollup merge of rust-lang#124500 - VladimirMakaev:lldb-str-formatters…
…, r=Mark-Simulacrum lldb-formatters: Use StdSliceSyntheticProvider for &str &str has associated summary provider which correctly displays string values in debugger, but while working on rust-lang#124458 I've noticed that a &str inside an enum displays a blob of memory until a 0 is reached (as a c-string) which makes a very bizarre experience when debugging However there is already StdSliceSyntheticProvider which we use for other slices. This PR enables the same synthetic provider to be used for &str, however the summary provider is still fixed to return the string value I've added a test `debuginfo/strings-and-strs.rs` which prior to this PR would output the following in LLDB: ``` * thread #1, name = 'a', stop reason = breakpoint 1.1 frame #0: 0x0000555555556383 a`strings_and_strs::main::h1d2b5f9227b8767d at strings-and-strs.rs:47:5 44 let plain_str = "Hello"; 45 let str_in_struct = Foo { inner: "Hello" }; 46 let str_in_tuple = ("Hello", "World"); -> 47 zzz(); // #break 48 } 49 50 fn zzz() { (lldb) frame var (alloc::string::String) plain_string = "Hello" { vec = size=5 { [0] = 'H' [1] = 'e' [2] = 'l' [3] = 'l' [4] = 'o' } } (&str) plain_str = "Hello" { data_ptr = 0x0000555555557263 "HelloWorld\U00000001gdb_load_rust_pretty_printers.py" length = 5 } (strings_and_strs::Foo) str_in_struct = { inner = "Hello" { data_ptr = 0x0000555555557263 "HelloWorld\U00000001gdb_load_rust_pretty_printers.py" length = 5 } } ((&str, &str)) str_in_tuple = { 0 = "Hello" { data_ptr = 0x0000555555557263 "HelloWorld\U00000001gdb_load_rust_pretty_printers.py" length = 5 } 1 = "World" { data_ptr = 0x0000555555557268 "World\U00000001gdb_load_rust_pretty_printers.py" length = 5 } } ``` After this PR it would look the following way: ``` * thread #1, name = 'a', stop reason = breakpoint 1.1 frame #0: 0x0000555555556383 a`strings_and_strs::main::h1d2b5f9227b8767d at strings-and-strs.rs:47:5 44 let plain_str = "Hello"; 45 let str_in_struct = Foo { inner: "Hello" }; 46 let str_in_tuple = ("Hello", "World"); -> 47 zzz(); // #break 48 } 49 50 fn zzz() { (lldb) frame var (alloc::string::String) plain_string = "Hello" { vec = size=5 { [0] = 'H' [1] = 'e' [2] = 'l' [3] = 'l' [4] = 'o' } } (&str) plain_str = "Hello" { [0] = 'H' [1] = 'e' [2] = 'l' [3] = 'l' [4] = 'o' } (strings_and_strs::Foo) str_in_struct = { inner = "Hello" { [0] = 'H' [1] = 'e' [2] = 'l' [3] = 'l' [4] = 'o' } } ((&str, &str)) str_in_tuple = { 0 = "Hello" { [0] = 'H' [1] = 'e' [2] = 'l' [3] = 'l' [4] = 'o' } 1 = "World" { [0] = 'W' [1] = 'o' [2] = 'r' [3] = 'l' [4] = 'd' } } ```
Configuration menu - View commit details
-
Copy full SHA for 74c1289 - Browse repository at this point
Copy the full SHA 74c1289View commit details -
Rollup merge of rust-lang#124677 - djkoloski:set_fuchsia_frame_pointe…
…r, r=tmandry Set non-leaf frame pointers on Fuchsia targets This is part of our work to enable shadow call stack sanitization on Fuchsia, see [this Fuchsia issue](https://g-issues.fuchsia.dev/issues/327643884). r? `@tmandry`
Configuration menu - View commit details
-
Copy full SHA for 31099d5 - Browse repository at this point
Copy the full SHA 31099d5View commit details -
Rollup merge of rust-lang#124692 - workingjubilee:document-no-double-…
…pointer-coercion-happens, r=compiler-errors We do not coerce `&mut &mut T -> *mut mut T` Resolves rust-lang#34117 by declaring it to be "working as intended" until someone RFCs it or whatever other lang proposal would be required. It seems a bit of a footgun, but perhaps there are strong reasons to allow it anyways. Seeing as how I often have to be mindful to not allow a pointer to coerce the wrong way in my FFI work, I am inclined to think not, but perhaps it's fine in some use-case and that's actually more common?
Configuration menu - View commit details
-
Copy full SHA for e82ed82 - Browse repository at this point
Copy the full SHA e82ed82View commit details