interpret, miri: uniform treatments of intrinsics/functions with and without return block #124715
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A long time ago we didn't have a
dest: &MPlaceTy<'tcx, Self::Provenance>
for diverging functions, and sincedest
is used so often we special-cased these non-returning intrinsics and functions so that we'd havedest
available everywhere else. But this has changed a while ago, now only the return blockret
is optional, and there's a convenientreturn_to_block
function for dealing with theNone
case.So there no longer is any reason to treat diverging intrinsics/functions any different from those that do return.