Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use correct Hermit links in The rustc Book #124723

Merged
merged 3 commits into from
May 4, 2024

Conversation

onkoe
Copy link
Contributor

@onkoe onkoe commented May 4, 2024

As is, this documentation links to the old Hermit organization, hermitcore, which isn't used anymore.

I've updated the links to point to the new organization. This PR also changes the incorrect "rusty loader" link to point to the new hermit-rs-template repo.

(fixes #124722)

the Hermit team seems to have moved from `hermitcore` to
`hermit-os` on GitHub. this change corrects the old links on its
target page.
@rustbot
Copy link
Collaborator

rustbot commented May 4, 2024

Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @ehuss (or someone else) some time within the next two weeks.

Please see the contribution instructions for more information. Namely, in order to ensure the minimum review times lag, PR authors and assigned reviewers should ensure that the review label (S-waiting-on-review and S-waiting-on-author) stays updated, invoking these commands when appropriate:

  • @rustbot author: the review is finished, PR author should check the comments and take action accordingly
  • @rustbot review: the author is ready for a review, this PR will be queued again in the reviewer's queue

@rustbot
Copy link
Collaborator

rustbot commented May 4, 2024

Some changes occurred in src/doc/rustc/src/platform-support

cc @Nilstrieb

@rustbot rustbot added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label May 4, 2024
Both are renamed! Sorry for the initial incorrect commit,
but this should correct it. 😄
@workingjubilee workingjubilee added the O-hermit Operating System: Hermit label May 4, 2024
Co-authored-by: Jubilee <46493976+workingjubilee@users.noreply.github.com>
@workingjubilee
Copy link
Member

Nice!
@bors r+ rollup

@bors
Copy link
Contributor

bors commented May 4, 2024

📌 Commit 3abefa1 has been approved by workingjubilee

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels May 4, 2024
bors added a commit to rust-lang-ci/rust that referenced this pull request May 4, 2024
…iaskrgr

Rollup of 10 pull requests

Successful merges:

 - rust-lang#124501 (add support to override lldb binary path for ./x test)
 - rust-lang#124573 (add a reference link to the comment of the "cc" and "cmake".)
 - rust-lang#124663 (Enable reusing CI Docker cache when running CI images locally)
 - rust-lang#124690 (Only consider ambiguous goals when finding best obligation for ambiguities)
 - rust-lang#124713 (Update Cargo specific diagnostics in check-cfg)
 - rust-lang#124717 (Implement `do_not_recommend` in the new solver)
 - rust-lang#124718 (Record impl args in the proof tree)
 - rust-lang#124720 (interpret: Drop: always evaluate place)
 - rust-lang#124721 (library/std: Fix build for NetBSD targets with 32-bit `c_long`)
 - rust-lang#124723 (Use correct Hermit links in The `rustc` Book)

r? `@ghost`
`@rustbot` modify labels: rollup
@bors bors merged commit e186740 into rust-lang:master May 4, 2024
6 checks passed
rust-timer added a commit to rust-lang-ci/rust that referenced this pull request May 4, 2024
Rollup merge of rust-lang#124723 - onkoe:issue-124722-fix, r=workingjubilee

Use correct Hermit links in The `rustc` Book

As is, this documentation links to the old Hermit organization, `hermitcore`, which isn't used anymore.

I've updated the links to point to the new organization. This PR also changes the incorrect "rusty loader" link to point to the new `hermit-rs-template` repo.

(fixes rust-lang#124722)
@rustbot rustbot added this to the 1.80.0 milestone May 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
O-hermit Operating System: Hermit S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

docs: Hermit targets link to wrong GitHub org
5 participants