Add rustfmt cfg to well known cfgs list
#124742
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
rustbot has assigned @michaelwoerister. Use |
rustbot
added
S-waiting-on-review
This comment has been minimized.
This comment has been minimized.
fmease
approved these changes
May 5, 2024
|
r? fmease @bors r+ rollup |
bors
added
S-waiting-on-bors
fmease
added a commit
to fmease/rust
that referenced
this pull request
May 5, 2024
Add `rustfmt` cfg to well known cfgs list This PR adds the `rustfmt` cfg to the well known cfgs list. Related to rust-lang#124735
Kobzol
reviewed
May 5, 2024
| // These four are never set by rustc, but we set them anyway: they | ||
| // should not trigger a lint because `cargo clippy`, `cargo doc`, | ||
| // `cargo test` and `cargo miri run` (respectively) can set them. | ||
| // These four are never set by rustc, but we set them anyway; they |
There was a problem hiding this comment.
Suggested change
| // These four are never set by rustc, but we set them anyway; they | |
| // These five are never set by rustc, but we set them anyway; they |
:)
There was a problem hiding this comment.
Ah, I've already created a rollup >.<
Can be a follow-up PR which also contains a comments that in reality rustfmt doesn't properly evaluate cfg specs but treats all of them as true via
bors
added a commit
to rust-lang-ci/rust
that referenced
this pull request
May 5, 2024
Rollup of 6 pull requests Successful merges: - rust-lang#124146 (Triagebot: Rename `macos` ping group to `apple`) - rust-lang#124742 (Add `rustfmt` cfg to well known cfgs list) - rust-lang#124745 (Implement lldb formattter for "clang encoded" enums (LLDB 18.1+) (v2)) - rust-lang#124747 (Support Result<T, E> across FFI when niche optimization can be used (v2)) - rust-lang#124765 ([rustdoc] Fix bad color for setting cog in ayu theme) - rust-lang#124768 ([resubmission] Meta: Enable the brand new triagebot transfer command) r? `@ghost` `@rustbot` modify labels: rollup
fmease
added a commit
to fmease/rust
that referenced
this pull request
May 5, 2024
Add `rustfmt` cfg to well known cfgs list This PR adds the `rustfmt` cfg to the well known cfgs list. Related to rust-lang#124735
bors
added a commit
to rust-lang-ci/rust
that referenced
this pull request
May 6, 2024
Rollup of 5 pull requests Successful merges: - rust-lang#124742 (Add `rustfmt` cfg to well known cfgs list) - rust-lang#124747 (Support Result<T, E> across FFI when niche optimization can be used (v2)) - rust-lang#124753 (Migrate `run-make/rustdoc-error-lines` to new `rmake.rs`) - rust-lang#124765 ([rustdoc] Fix bad color for setting cog in ayu theme) - rust-lang#124768 ([resubmission] Meta: Enable the brand new triagebot transfer command) r? `@ghost` `@rustbot` modify labels: rollup
matthiaskrgr
added a commit
to matthiaskrgr/rust
that referenced
this pull request
May 6, 2024
Add `rustfmt` cfg to well known cfgs list This PR adds the `rustfmt` cfg to the well known cfgs list. Related to rust-lang#124735
This was referenced May 6, 2024
bors
added a commit
to rust-lang-ci/rust
that referenced
this pull request
May 6, 2024
…iaskrgr Rollup of 3 pull requests Successful merges: - rust-lang#124742 (Add `rustfmt` cfg to well known cfgs list) - rust-lang#124765 ([rustdoc] Fix bad color for setting cog in ayu theme) - rust-lang#124768 ([resubmission] Meta: Enable the brand new triagebot transfer command) r? `@ghost` `@rustbot` modify labels: rollup
rust-timer
added a commit
to rust-lang-ci/rust
that referenced
this pull request
May 6, 2024
Rollup merge of rust-lang#124742 - Urgau:check-cfg-rustfmt, r=fmease Add `rustfmt` cfg to well known cfgs list This PR adds the `rustfmt` cfg to the well known cfgs list. Related to rust-lang#124735
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds the
rustfmtcfg to the well known cfgs list.Related to #124735