Stabilize byte_slice_trim_ascii for &[u8]/&str
#124928
Conversation
|
rustbot has assigned @workingjubilee. Use |
rustbot
added
S-waiting-on-review
This comment has been minimized.
This comment has been minimized.
library/core/src/slice/ascii.rs
Outdated
| /// `u8::is_ascii_whitespace`. | ||
| /// [`u8::is_ascii_whitespace`]. | ||
| /// | ||
| /// [`u8::is_ascii_whitespace`]: u8::is_ascii_whitespace |
There was a problem hiding this comment.
? is this explicit doc link actually required? it's my experience that this sort of thing actually links by itself nowadays as long as the [] are used. certainly this part is linked, right?
rust/library/core/src/slice/ascii.rs
Line 208 in 69ae958
There was a problem hiding this comment.
Looks like it's not required, I guess I still do that out of caution/habit.
I can remove the explicit links.
There was a problem hiding this comment.
Removed in the latest force push at 9fb49fa.
There was a problem hiding this comment.
it's an understandable tic, yeah.
Remove feature from documentation examples Add rustc_const_stable attribute to stabilized functions Update intra-doc link for `u8::is_ascii_whitespace` on `&[u8]` functions
|
everything appears to be in order. thank you! @bors r+ rollup |
bors
added
S-waiting-on-bors
…iaskrgr Rollup of 5 pull requests Successful merges: - rust-lang#124928 (Stabilize `byte_slice_trim_ascii` for `&[u8]`/`&str`) - rust-lang#124954 (Document proper usage of `fmt::Error` and `fmt()`'s `Result`.) - rust-lang#124969 (check if `x test tests` missing any test directory) - rust-lang#124978 (Handle Deref expressions in invalid_reference_casting) - rust-lang#125005 (Miri subtree update) r? `@ghost` `@rustbot` modify labels: rollup
Rollup merge of rust-lang#124928 - okaneco:trim_ascii, r=workingjubilee Stabilize `byte_slice_trim_ascii` for `&[u8]`/`&str` Remove feature from documentation examples Update intra-doc link for `u8::is_ascii_whitespace` on `&[u8]` functions Closes rust-lang#94035 FCP has successfully completed rust-lang#94035 (comment)
Remove feature from documentation examples
Update intra-doc link for
u8::is_ascii_whitespaceon&[u8]functionsCloses #94035
FCP has successfully completed #94035 (comment)