Rename ${length()} to ${len()}

[workingjubilee]

Implements the rename suggested in #122808 (comment)

I brought this up in the doc PR but it belongs here – length should probably be renamed len before stabilization. The latter is de facto standard in the standard library, whereas the former is only used in a single unstable API. These metafunctions aren’t library items of course, but should presumably still be consistent with established names.

r? @c410-f3r

[rustbot]

Failed to set assignee to c410-f3r: invalid assignee

Note: Only org members with at least the repository "read" role, users with write permissions, or people who have commented on the PR may be assigned.

[c410-f3r]

length is the identifier chosen and accepted in the RFC (rust-lang/rfcs#3086).

Any changes should probably occur with the authorization of the responsible team.

cc @markbt

[workingjubilee]

r? lang

[scottmcm]

Nominating for team discussion. I'm pretty sure this is lang, but I also would be interested in libs-api's opinion for things like this (similar to Err vs Error choices).

[joshtriplett]

We discussed this in today's @rust-lang/libs-api meeting. We had a consensus that the standard library consistently uses "len" and not "length", and we recommend that this should be consistent with that as well.

[joshtriplett]

We discussed this in today's @rust-lang/lang meeting. We agreed that we should rename this for consistency with usage in the standard library.

Please go ahead with the rename.

[c410-f3r]

Code changes LGTM

[workingjubilee]

hmm, it seems T-libs-api!Josh Triplett and T-lang!Josh Triplett gave it the go-ahead, so

@bors r=c410-f3r,joshtriplett,joshtriplett

that's how it works, right? :^)

[bors]

📌 Commit 6e74155 has been approved by c410-f3r,joshtriplett,joshtriplett

It is now in the queue for this repository.

[bors]

⌛ Testing commit 6e74155 with merge b71e8cb...

[bors]

☀️ Test successful - checks-actions
Approved by: c410-f3r,joshtriplett,joshtriplett
Pushing b71e8cb to master...

[rust-timer]

Finished benchmarking commit (b71e8cb): comparison URL.

Overall result: no relevant changes - no action needed

@rustbot label: -perf-regression

Instruction count

This benchmark run did not return any relevant results for this metric.

Max RSS (memory usage)

Results (primary 5.8%, secondary 3.8%)

This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.

	mean	range	count
Regressions ❌ (primary)	5.8%	[5.8%, 5.8%]	1
Regressions ❌ (secondary)	3.8%	[3.8%, 3.8%]	1
Improvements ✅ (primary)	-	-	0
Improvements ✅ (secondary)	-	-	0
All ❌✅ (primary)	5.8%	[5.8%, 5.8%]	1

Cycles

This benchmark run did not return any relevant results for this metric.

Binary size

This benchmark run did not return any relevant results for this metric.

Bootstrap: 678.078s -> 679.795s (0.25%)
Artifact size: 316.18 MiB -> 316.18 MiB (-0.00%)