Skip to content

Conversation

compiler-errors
Copy link
Member

Removes some unncessary redundancy between SpannedWhereClause/WhereClause

r? lcnr

@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. labels May 10, 2024
@rustbot
Copy link
Collaborator

rustbot commented May 10, 2024

changes to the core type system

cc @compiler-errors, @lcnr

Copy link
Contributor

@lcnr lcnr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

r=me after nits

@lcnr
Copy link
Contributor

lcnr commented May 11, 2024

@bors r+ rollup

@bors
Copy link
Collaborator

bors commented May 11, 2024

📌 Commit e444017 has been approved by lcnr

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels May 11, 2024
@lcnr
Copy link
Contributor

lcnr commented May 11, 2024

@bors rollup=iffy

@bors
Copy link
Collaborator

bors commented May 11, 2024

⌛ Testing commit e444017 with merge 78a7751...

@bors
Copy link
Collaborator

bors commented May 11, 2024

☀️ Test successful - checks-actions
Approved by: lcnr
Pushing 78a7751 to master...

@bors bors added the merged-by-bors This PR was explicitly merged by bors. label May 11, 2024
@bors bors merged commit 78a7751 into rust-lang:master May 11, 2024
@rustbot rustbot added this to the 1.80.0 milestone May 11, 2024
@rust-timer
Copy link
Collaborator

Finished benchmarking commit (78a7751): comparison URL.

Overall result: no relevant changes - no action needed

@rustbot label: -perf-regression

Instruction count

This benchmark run did not return any relevant results for this metric.

Max RSS (memory usage)

Results

This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.

mean range count
Regressions ❌
(primary)
- - 0
Regressions ❌
(secondary)
- - 0
Improvements ✅
(primary)
-2.2% [-2.2%, -2.2%] 1
Improvements ✅
(secondary)
-4.1% [-4.1%, -4.1%] 1
All ❌✅ (primary) -2.2% [-2.2%, -2.2%] 1

Cycles

This benchmark run did not return any relevant results for this metric.

Binary size

This benchmark run did not return any relevant results for this metric.

Bootstrap: 673.703s -> 674.128s (0.06%)
Artifact size: 315.98 MiB -> 315.87 MiB (-0.03%)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
merged-by-bors This PR was explicitly merged by bors. S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants