Skip to content

Conversation

matthiaskrgr
Copy link
Member

Successful merges:

r? @ghost
@rustbot modify labels: rollup

Create a similar rollup

devnexen and others added 8 commits May 6, 2024 13:31
…k-Simulacrum

std::rand: adding solaris/illumos for getrandom support.

To help solarish support for miri https://rust-lang/miri#3567
…crum

Update ena to 0.14.3

Includes rust-lang/ena#53, which removes a trivial `Self: Sized` bound that prevents `ena` from building on the new solver.
Fix typo in ManuallyDrop's documentation

```diff
- /// A wrapper to inhibit compiler from automatically calling `T`’s destructor.
+ /// A wrapper to inhibit the compiler from automatically calling `T`’s destructor.
```
…ttmcm

Add @saethlin to some triagebot groups

I think this is a reasonable approximation of what I can review, and should encourage people to request me.

r? scottmcm
@rustbot rustbot added A-meta Area: Issues & PRs about the rust-lang/rust repository itself O-unix Operating system: Unix-like S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. T-libs Relevant to the library team, which will review and decide on the PR/issue. rollup A PR which is a rollup labels May 11, 2024
@matthiaskrgr
Copy link
Member Author

@bors r+ rollup=never p=4

@bors
Copy link
Collaborator

bors commented May 11, 2024

📌 Commit a4317c4 has been approved by matthiaskrgr

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels May 11, 2024
@bors
Copy link
Collaborator

bors commented May 11, 2024

⌛ Testing commit a4317c4 with merge be7549f...

@bors
Copy link
Collaborator

bors commented May 11, 2024

☀️ Test successful - checks-actions
Approved by: matthiaskrgr
Pushing be7549f to master...

@bors bors added the merged-by-bors This PR was explicitly merged by bors. label May 11, 2024
@bors bors merged commit be7549f into rust-lang:master May 11, 2024
@rustbot rustbot added this to the 1.80.0 milestone May 11, 2024
@rust-timer
Copy link
Collaborator

📌 Perf builds for each rolled up PR:

PR# Message Perf Build Sha
#124766 std::rand: adding solaris/illumos for getrandom support. cd06b2f8d72c33692ae84048eb603b87f0bdb265 (link)
#124818 Update ena to 0.14.3 23522cdea7882027745004b80ee027d194e07c89 (link)
#124991 Fix typo in ManuallyDrop's documentation cfd6d32f2221d137d57d2f900cdcdd262bab13bd (link)
#124994 Add @saethlin to some triagebot groups 48668f18e5bf2d7eb0aef4eccc3de1c96dd123ea (link)

previous master: ef15976387

In the case of a perf regression, run the following command for each PR you suspect might be the cause: @rust-timer build $SHA

@rust-timer
Copy link
Collaborator

Finished benchmarking commit (be7549f): comparison URL.

Overall result: ✅ improvements - no action needed

@rustbot label: -perf-regression

Instruction count

This is a highly reliable metric that was used to determine the overall result at the top of this comment.

mean range count
Regressions ❌
(primary)
- - 0
Regressions ❌
(secondary)
- - 0
Improvements ✅
(primary)
- - 0
Improvements ✅
(secondary)
-1.4% [-1.4%, -1.4%] 1
All ❌✅ (primary) - - 0

Max RSS (memory usage)

Results

This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.

mean range count
Regressions ❌
(primary)
2.1% [2.1%, 2.1%] 1
Regressions ❌
(secondary)
- - 0
Improvements ✅
(primary)
- - 0
Improvements ✅
(secondary)
- - 0
All ❌✅ (primary) 2.1% [2.1%, 2.1%] 1

Cycles

This benchmark run did not return any relevant results for this metric.

Binary size

This benchmark run did not return any relevant results for this metric.

Bootstrap: 677.207s -> 675.209s (-0.30%)
Artifact size: 316.00 MiB -> 315.95 MiB (-0.01%)

@matthiaskrgr matthiaskrgr deleted the rollup-cc9lc2y branch September 1, 2024 17:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-meta Area: Issues & PRs about the rust-lang/rust repository itself merged-by-bors This PR was explicitly merged by bors. O-unix Operating system: Unix-like rollup A PR which is a rollup S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. T-libs Relevant to the library team, which will review and decide on the PR/issue.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

8 participants