Skip to content

Conversation

@BoxyUwU
Copy link
Member

@BoxyUwU BoxyUwU commented May 17, 2024

No description provided.

@rustbot
Copy link
Collaborator

rustbot commented May 17, 2024

r? @Mark-Simulacrum

rustbot has assigned @Mark-Simulacrum.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

@rustbot
Copy link
Collaborator

rustbot commented May 17, 2024

triagebot.toml has been modified, there may have been changes to the review queue.

cc @davidtwco, @wesleywiser

@rustbot rustbot added A-meta Area: Issues & PRs about the rust-lang/rust repository itself S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels May 17, 2024
@joboet
Copy link
Member

joboet commented May 17, 2024

@bors r+ rollup

@bors
Copy link
Collaborator

bors commented May 17, 2024

📌 Commit cf3414a has been approved by joboet

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels May 17, 2024
@bors
Copy link
Collaborator

bors commented May 17, 2024

⌛ Testing commit cf3414a with merge c7716d5...

@bors
Copy link
Collaborator

bors commented May 17, 2024

☀️ Test successful - checks-actions
Approved by: joboet
Pushing c7716d5 to master...

@bors bors added the merged-by-bors This PR was explicitly merged by bors. label May 17, 2024
@bors bors merged commit c7716d5 into rust-lang:master May 17, 2024
@rustbot rustbot added this to the 1.80.0 milestone May 17, 2024
@rust-timer
Copy link
Collaborator

Finished benchmarking commit (c7716d5): comparison URL.

Overall result: no relevant changes - no action needed

@rustbot label: -perf-regression

Instruction count

This benchmark run did not return any relevant results for this metric.

Max RSS (memory usage)

Results (primary 0.6%)

This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.

mean range count
Regressions ❌
(primary)
0.6% [0.2%, 1.1%] 2
Regressions ❌
(secondary)
- - 0
Improvements ✅
(primary)
- - 0
Improvements ✅
(secondary)
- - 0
All ❌✅ (primary) 0.6% [0.2%, 1.1%] 2

Cycles

Results (primary -1.9%, secondary 1.2%)

This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.

mean range count
Regressions ❌
(primary)
1.6% [1.1%, 2.1%] 2
Regressions ❌
(secondary)
3.1% [1.9%, 4.3%] 4
Improvements ✅
(primary)
-4.2% [-6.3%, -2.2%] 3
Improvements ✅
(secondary)
-2.5% [-3.2%, -1.8%] 2
All ❌✅ (primary) -1.9% [-6.3%, 2.1%] 5

Binary size

This benchmark run did not return any relevant results for this metric.

Bootstrap: 668.179s -> 670.062s (0.28%)
Artifact size: 316.10 MiB -> 316.15 MiB (0.02%)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

A-meta Area: Issues & PRs about the rust-lang/rust repository itself merged-by-bors This PR was explicitly merged by bors. S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants