Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

android: use posix_memalign for aligned allocations #125244

Merged
merged 1 commit into from
May 18, 2024

Conversation

RalfJung
Copy link
Member

Our target page says

Rust will support the most recent Long Term Support (LTS) Android Native Development Kit (NDK). By default Rust will support all API levels supported by the NDK, but a higher minimum API level may be required if deemed necessary.

According to this, the minimum API level of the current LTS NDK is 21. According to this, posix_memalign exists since API level 16. So I think we should be able to use it here?

@rustbot
Copy link
Collaborator

rustbot commented May 18, 2024

r? @cuviper

rustbot has assigned @cuviper.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

@rustbot rustbot added O-unix Operating system: Unix-like S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-libs Relevant to the library team, which will review and decide on the PR/issue. labels May 18, 2024
@workingjubilee
Copy link
Member

@RalfJung this is waiting on #120593

@workingjubilee workingjubilee added the S-blocked Status: Marked as blocked ❌ on something else such as an RFC or other implementation work. label May 18, 2024
@workingjubilee
Copy link
Member

...wait, I'm an idiot, 19 is higher than 16.

@workingjubilee workingjubilee removed the S-blocked Status: Marked as blocked ❌ on something else such as an RFC or other implementation work. label May 18, 2024
@workingjubilee
Copy link
Member

Yeah, that's correct.

@bors r+

@bors
Copy link
Contributor

bors commented May 18, 2024

📌 Commit dde1134 has been approved by workingjubilee

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels May 18, 2024
@workingjubilee workingjubilee added the O-android Operating system: Android label May 18, 2024
@bors
Copy link
Contributor

bors commented May 18, 2024

⌛ Testing commit dde1134 with merge cf2baaa...

@bors
Copy link
Contributor

bors commented May 18, 2024

☀️ Test successful - checks-actions
Approved by: workingjubilee
Pushing cf2baaa to master...

@bors bors added the merged-by-bors This PR was explicitly merged by bors. label May 18, 2024
@bors bors merged commit cf2baaa into rust-lang:master May 18, 2024
7 checks passed
@rustbot rustbot added this to the 1.80.0 milestone May 18, 2024
@rust-timer
Copy link
Collaborator

Finished benchmarking commit (cf2baaa): comparison URL.

Overall result: no relevant changes - no action needed

@rustbot label: -perf-regression

Instruction count

This benchmark run did not return any relevant results for this metric.

Max RSS (memory usage)

Results (primary 3.9%)

This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.

mean range count
Regressions ❌
(primary)
3.9% [3.9%, 3.9%] 1
Regressions ❌
(secondary)
- - 0
Improvements ✅
(primary)
- - 0
Improvements ✅
(secondary)
- - 0
All ❌✅ (primary) 3.9% [3.9%, 3.9%] 1

Cycles

This benchmark run did not return any relevant results for this metric.

Binary size

This benchmark run did not return any relevant results for this metric.

Bootstrap: 669.005s -> 671.867s (0.43%)
Artifact size: 316.23 MiB -> 316.05 MiB (-0.06%)

@RalfJung RalfJung deleted the android-alloc branch May 19, 2024 08:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
merged-by-bors This PR was explicitly merged by bors. O-android Operating system: Android O-unix Operating system: Unix-like S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-libs Relevant to the library team, which will review and decide on the PR/issue.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants