Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rollup of 7 pull requests #125425

Closed
wants to merge 19 commits into from
Closed

Rollup of 7 pull requests #125425

wants to merge 19 commits into from

Commits on May 22, 2024

  1. Migrate run-make/rustdoc-scrape-examples-macros to rmake.rs

    @GuillaumeGomez
    GuillaumeGomez committed May 22, 2024
    Configuration menu
    Copy the full SHA
    fc76015 View commit details
    Browse the repository at this point in the history

  2. Directly add extension instead of using Path::with_extension 

    `Path::with_extension` has a nice footgun when the original path doesn't
contain an extension: Anything after the last dot gets removed.
    @tbu-
    tbu- committed May 22, 2024
    Configuration menu
    Copy the full SHA
    87b77a2 View commit details
    Browse the repository at this point in the history

  3. Rename FrameworkOnlyWindows to RawDylibOnlyWindows 

    Frameworks are Apple-specific, no idea why it had "framework" in the
name before.
    @tbu-
    tbu- committed May 22, 2024
    Configuration menu
    Copy the full SHA
    72968e5 View commit details
    Browse the repository at this point in the history

  4. Use correct param-env in MissingCopyImplementations

    @compiler-errors
    compiler-errors committed May 22, 2024
    Configuration menu
    Copy the full SHA
    8369dbb View commit details
    Browse the repository at this point in the history

  5. Clarify the meaning of the span within mbe::TokenTree::MetaVar.

    @nnethercote
    nnethercote committed May 22, 2024
    Configuration menu
    Copy the full SHA
    c8844df View commit details
    Browse the repository at this point in the history

  6. Clarify parse a little. 

    - Name the colon span as `colon_span` to distinguish it from the other
  `span` local variable.
- Just use basic pattern matching, which is easier to read than `map_or`.
    @nnethercote
    nnethercote committed May 22, 2024
    Configuration menu
    Copy the full SHA
    3fc8f89 View commit details
    Browse the repository at this point in the history

  7. Clarify a comment.

    @nnethercote
    nnethercote committed May 22, 2024
    Configuration menu
    Copy the full SHA
    b6de782 View commit details
    Browse the repository at this point in the history

  8. Convert some token_joint_hidden calls to token_joint. 

    This has no noticeable effect, but it makes these cases follow the
guidelines in the comments on `Spacing`, which say that `Joint` should
be used "for each token that (a) should be pretty-printed without a
space after it, and (b) is followed by a punctuation token".

These two tokens are both followed by a comma, which is a punctuation
token.
    @nnethercote
    nnethercote committed May 22, 2024
    Configuration menu
    Copy the full SHA
    c679a55 View commit details
    Browse the repository at this point in the history

  9. Use JointHidden in a couple of suitable places. 

    This has no notable effect, but it's appropriate because the relevant
tokens are followed by delimiters.
    @nnethercote
    nnethercote committed May 22, 2024
    Configuration menu
    Copy the full SHA
    a1b6d46 View commit details
    Browse the repository at this point in the history

  10. Add some comments.

    @nnethercote
    nnethercote committed May 22, 2024
    Configuration menu
    Copy the full SHA
    4d513cb View commit details
    Browse the repository at this point in the history

  11. Cleanup: Fix up some diagnostics

    @fmease
    fmease committed May 22, 2024
    Configuration menu
    Copy the full SHA
    ae49dbe View commit details
    Browse the repository at this point in the history

  12. Add some tests for public-private dependencies.

    @ehuss
    ehuss committed May 22, 2024
    Configuration menu
    Copy the full SHA
    07b7cd6 View commit details
    Browse the repository at this point in the history

  13. Rollup merge of rust-lang#122665 - ehuss:pub-priv-tests, r=davidtwco 

    Add some tests for public-private dependencies.

This adds some tests to show more scenarios for the `exported_private_dependencies` lint. Several of these illustrate that the lint is not working as expected, and I have annotated those places with `FIXME`.

Note also that this includes some diamond dependency structures which compiletest doesn't exactly support. However, I don't think it should be a problem, it just results in the common dependency being built twice.
    @fmease
    fmease authored May 22, 2024
    Configuration menu
    Copy the full SHA
    53e1f7a View commit details
    Browse the repository at this point in the history

  14. Rollup merge of rust-lang#125210 - fmease:fix-up-some-diags, r=davidtwco 

    Cleanup: Fix up some diagnostics

Several diagnostics contained their error code inside their primary message which is no bueno.
This PR moves them out of the message and turns them into structured error codes.

Also fixes another occurrence of `->` after a selector in a Fluent message which is not correct. I've fixed two other instances of this issue in rust-lang#104345 (2022) but didn't update all instances as I've noted here: rust-lang#104345 (comment) (“the future is now!”).
    @fmease
    fmease authored May 22, 2024
    Configuration menu
    Copy the full SHA
    b935399 View commit details
    Browse the repository at this point in the history

  15. Rollup merge of rust-lang#125316 - nnethercote:tweak-Spacing, r=petro… 

    …chenkov

Tweak `Spacing` use

Some clean-up precursors to rust-lang#125174.

r? `@petrochenkov`
    @fmease
    fmease authored May 22, 2024
    Configuration menu
    Copy the full SHA
    75383b3 View commit details
    Browse the repository at this point in the history

  16. Rollup merge of rust-lang#125401 - GuillaumeGomez:migrate-rustdoc-scr… 

    …ape-examples-macros, r=jieyouxu

Migrate `run-make/rustdoc-scrape-examples-macros` to `rmake.rs`

Part of rust-lang#121876.

r? ``@jieyouxu``
    @fmease
    fmease authored May 22, 2024
    Configuration menu
    Copy the full SHA
    ec49176 View commit details
    Browse the repository at this point in the history

  17. Rollup merge of rust-lang#125406 - tbu-:pr_rm_path_with_extension, r=… 

    …Nadrieril

Directly add extension instead of using `Path::with_extension`

`Path::with_extension` has a nice footgun when the original path doesn't contain an extension: Anything after the last dot gets removed.
    @fmease
    fmease authored May 22, 2024
    Configuration menu
    Copy the full SHA
    aabe253 View commit details
    Browse the repository at this point in the history

  18. Rollup merge of rust-lang#125409 - tbu-:pr_raw_dylib_only_windows, r=… 

    …lcnr

Rename `FrameworkOnlyWindows` to `RawDylibOnlyWindows`

Frameworks are Apple-specific, no idea why it had "framework" in the name before.
    @fmease
    fmease authored May 22, 2024
    Configuration menu
    Copy the full SHA
    c4cfb88 View commit details
    Browse the repository at this point in the history

  19. Rollup merge of rust-lang#125416 - compiler-errors:param-env-missing-… 

    …copy, r=lcnr

Use correct param-env in `MissingCopyImplementations`

We shouldn't assume the param-env is empty for this lint, since although we check the struct has no parameters, there still may be trivial where-clauses.

fixes rust-lang#125394
    @fmease
    fmease authored May 22, 2024
    Configuration menu
    Copy the full SHA
    fb1bff5 View commit details
    Browse the repository at this point in the history