-
Notifications
You must be signed in to change notification settings - Fork 12.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Make lint: lint_dropping_references
lint_forgetting_copy_types
lint_forgetting_references
give suggestion if possible.
#125531
Make lint: lint_dropping_references
lint_forgetting_copy_types
lint_forgetting_references
give suggestion if possible.
#125531
Conversation
Failed to set assignee to
|
This comment has been minimized.
This comment has been minimized.
078441c
to
1028092
Compare
963e221
to
066c5e9
Compare
☔ The latest upstream changes (presumably #125433) made this pull request unmergeable. Please resolve the merge conflicts. |
…on as suggestion.
066c5e9
to
9d1ed80
Compare
@bors r+ |
☀️ Test successful - checks-actions |
Finished benchmarking commit (a83f933): comparison URL. Overall result: ✅ improvements - no action needed@rustbot label: -perf-regression Instruction countThis is a highly reliable metric that was used to determine the overall result at the top of this comment.
Max RSS (memory usage)Results (primary 0.0%)This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.
CyclesResults (primary 2.7%, secondary 3.0%)This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.
Binary sizeThis benchmark run did not return any relevant results for this metric. Bootstrap: 667.137s -> 667.715s (0.09%) |
This is a follow-up PR of #125433. When it's merged, I want change lint
dropping_copy_types
to use the sameSubdiagnostic
structUseLetUnderscoreIgnoreSuggestion
which is added in this PR.Hi, Thank you(@Urgau ) again for your help in the previous PR. If your time permits, please also take a look at this one.
r? compiler