Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rollup of 7 pull requests #125569

Closed
wants to merge 15 commits into from

Commits on May 21, 2024

  1. Configuration menu
    Copy the full SHA
    c773deb View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    d0b45a9 View commit details
    Browse the repository at this point in the history

Commits on May 22, 2024

  1. Add a comment

    Kobzol committed May 22, 2024
    Configuration menu
    Copy the full SHA
    ab73bb2 View commit details
    Browse the repository at this point in the history

Commits on May 25, 2024

  1. Configuration menu
    Copy the full SHA
    2782123 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    d7248d7 View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    bebcb4e View commit details
    Browse the repository at this point in the history
  4. Configuration menu
    Copy the full SHA
    0c84361 View commit details
    Browse the repository at this point in the history

Commits on May 26, 2024

  1. opt-dist: dont overrwite config.toml when verifying

    This is another step toward making opt-dist work in sandboxed environments
    
    opt-dist verifies the final built rustc against a subset of rustc test
    suite. However it overwrote the pre-existing `config.toml` [^1],
    and that results in ./vendor/ directory removed [^2].
    
    Instead of overwriting, this patch use `--set <config-value>` to
    override paths to rustc / cargo / llvm-config.
    
    [^1]: https://github.com/rust-lang/rust/blob/606afbb617a2949a4e35c4b0258ff94c980b9451/src/tools/opt-dist/src/tests.rs#L62-L77
    [^2]: https://github.com/rust-lang/rust/blob/8679004993f08807289911d9f400f4ac4391d2bc/src/bootstrap/bootstrap.py#L1057
    weihanglo committed May 26, 2024
    Configuration menu
    Copy the full SHA
    c81a40b View commit details
    Browse the repository at this point in the history
  2. Rollup merge of rust-lang#125307 - workingjubilee:uproot-entry-limit,…

    … r=Mark-Simulacrum
    
    tidy: stop special-casing tests/ui entry limit
    
    It is genuinely more annoying to have this error, now that this value is below the general `ENTRY_LIMIT` cap, when one is trying to clean out tests from tests/ui! This code has served its purpose well, let it rest now rather than force it to continue haunting us.
    matthiaskrgr authored May 26, 2024
    Configuration menu
    Copy the full SHA
    02ae27a View commit details
    Browse the repository at this point in the history
  3. Rollup merge of rust-lang#125375 - Kobzol:triagebot-rfl-ping-group, r…

    …=Mark-Simulacrum
    
    Create a triagebot ping group for Rust for Linux
    
    Corresponding rustc-dev-guide PR [here](rust-lang/rustc-dev-guide#1984). Discussed on [Zulip](https://rust-lang.zulipchat.com/#narrow/stream/242791-t-infra/topic/Testing.20Rust.20for.20Linux.20in.20our.20CI).
    matthiaskrgr authored May 26, 2024
    Configuration menu
    Copy the full SHA
    15424a8 View commit details
    Browse the repository at this point in the history
  4. Rollup merge of rust-lang#125473 - weihanglo:respect-existing-config-…

    …toml, r=Kobzol
    
    fix(opt-dist): respect existing config.toml
    
    This is another step toward making opt-dist work in sandboxed environments. See also <rust-lang#125465>.
    
    opt-dist verifies the final built rustc against a subset of rustc test
    suite. However it overwrote the pre-existing `config.toml` [^1],
    and that results in ./vendor/ directory removed [^2].
    
    Instead of overwriting, this patch use `--set <config-value>` to
    override paths to rustc / cargo / llvm-config.
    
    [^1]: https://github.com/rust-lang/rust/blob/606afbb617a2949a4e35c4b0258ff94c980b9451/src/tools/opt-dist/src/tests.rs#L62-L77
    [^2]: https://github.com/rust-lang/rust/blob/8679004993f08807289911d9f400f4ac4391d2bc/src/bootstrap/bootstrap.py#L1057
    matthiaskrgr authored May 26, 2024
    Configuration menu
    Copy the full SHA
    773ba21 View commit details
    Browse the repository at this point in the history
  5. Rollup merge of rust-lang#125508 - scottmcm:fix-125506, r=Nilstrieb

    Stop SRoA'ing `DynMetadata` in MIR
    
    Fixes rust-lang#125506
    matthiaskrgr authored May 26, 2024
    Configuration menu
    Copy the full SHA
    aba81b5 View commit details
    Browse the repository at this point in the history
  6. Rollup merge of rust-lang#125530 - SparrowLii:expand2, r=petrochenkov

    cleanup dependence of `ExtCtxt` in transcribe when macro expansion
    
    part of rust-lang#125356
    We can remove `transcribe`’s dependence on `ExtCtxt` to facilitate subsequent work (such as moving macro expansion into the incremental compilation system)
    
    r? ````@petrochenkov````
    Thanks for the reviewing!
    matthiaskrgr authored May 26, 2024
    Configuration menu
    Copy the full SHA
    a700f73 View commit details
    Browse the repository at this point in the history
  7. Rollup merge of rust-lang#125544 - Urgau:check-cfg-mention-cargo-spec…

    …ific, r=Mark-Simulacrum
    
    Also mention my-self for other check-cfg docs changes
    
    This PR adds a mention for my-self for the recently added `src/doc/rustc/src/check-cfg` directory.
    
    *I had to add a second mention just for the directory since [`Path::starts_with`](https://doc.rust-lang.org/std/path/struct.Path.html#method.starts_with) as used by [triagebot](https://github.com/rust-lang/triagebot/blob/48f29f351cae774caa90f555fbbc6d0df7dce80e/src/handlers/mentions.rs#L69), matches on path components and so can never return true for a file and directory at the same time.*
    matthiaskrgr authored May 26, 2024
    Configuration menu
    Copy the full SHA
    7000c1c View commit details
    Browse the repository at this point in the history
  8. Rollup merge of rust-lang#125559 - scottmcm:simplify-shift-ubcheck, r…

    …=workingjubilee
    
    Simplify the `unchecked_sh[lr]` ub-checks a bit
    
    It can use the constant in the check, rather than passing it as a parameter.
    matthiaskrgr authored May 26, 2024
    Configuration menu
    Copy the full SHA
    ac9558d View commit details
    Browse the repository at this point in the history