-
Notifications
You must be signed in to change notification settings - Fork 13.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Rewrite fpic
, simple-dylib
and issue-37893
run-make
tests in rmake.rs
or ui test format
#125662
Merged
Merged
Changes from all commits
Commits
Show all changes
3 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file was deleted.
Oops, something went wrong.
This file was deleted.
Oops, something went wrong.
This file was deleted.
Oops, something went wrong.
File renamed without changes.
File renamed without changes.
File renamed without changes.
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,15 @@ | ||
// a.rs is a procedural macro crate, on which b.rs and c.rs depend. A now | ||
// patched bug caused a compilation failure if the proc-macro crate was | ||
// initialized with its dependents in this exact order. This test checks | ||
// that compilation succeeds even when initialization is done in this order. | ||
// See https://github.com/rust-lang/rust/issues/37893 | ||
|
||
//@ ignore-cross-compile | ||
|
||
use run_make_support::rustc; | ||
|
||
fn main() { | ||
rustc().input("a.rs").run(); | ||
rustc().input("b.rs").run(); | ||
rustc().input("c.rs").run(); | ||
} |
This file was deleted.
Oops, something went wrong.
This file was deleted.
Oops, something went wrong.
This file was deleted.
Oops, something went wrong.
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,12 @@ | ||
// `-z text` caused the linker to error if there were any non-position-independent | ||
// code (PIC) sections. This test checks that this no longer happens. | ||
// See https://github.com/rust-lang/rust/pull/39803 | ||
|
||
//@ ignore-windows | ||
//@ ignore-macos | ||
//@ ignore-cross-compile | ||
|
||
//@ compile-flags: -Clink-args=-Wl,-z,text | ||
//@ run-pass | ||
|
||
fn main() {} |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,4 @@ | ||
//@ compile-flags: -Cprefer-dynamic | ||
|
||
#![crate_type = "dylib"] | ||
pub fn bar() {} |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,12 @@ | ||
// A simple test, where foo.rs has a dependency | ||
// on the dynamic library simple-dylib.rs. If the test passes, | ||
// dylibs can be built and linked into another file successfully.. | ||
|
||
//@ aux-crate:bar=simple-dylib.rs | ||
//@ run-pass | ||
|
||
extern crate bar; | ||
|
||
fn main() { | ||
bar::bar(); | ||
} |
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Observation: that sure is some fun combination to diagnose and fix...