Add Duration::new_{checked,unchecked} constructors
#125749
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
`Duration::new_checked()` returns `None` in cases where `Duration::new()` would panic. `Duration::new_unchecked()` requires that the provided nanosecond count be less than 1 billion (the number of nanoseconds in a second).
|
rustbot has assigned @Mark-Simulacrum. Use |
rustbot
added
S-waiting-on-review
3 tasks
jmillikin
force-pushed
the
duration-new-checked
branch
from
9eae151 to
d1839c2
Compare
This comment has been minimized.
This comment has been minimized.
jmillikin
force-pushed
the
duration-new-checked
branch
2 times, most recently
from
e1a52e4 to
fd0e24d
Compare
This comment has been minimized.
This comment has been minimized.
jmillikin
force-pushed
the
duration-new-checked
branch
from
fd0e24d to
a810b77
Compare
|
Per rust-lang/libs-team#117 (comment), only |
|
I have no need for I'll keep this PR open until @the8472 can weigh in on the assembly listings in the ACP. If there's truly no interest from the Rust devs regarding |
oriongonza
reviewed
May 30, 2024
jmillikin
force-pushed
the
duration-new-checked
branch
from
a810b77 to
1f05027
Compare
This comment has been minimized.
This comment has been minimized.
jmillikin
force-pushed
the
duration-new-checked
branch
from
1f05027 to
7964ef4
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Duration::new_checked()returnsNonein cases whereDuration::new()would panic.Duration::new_unchecked()requires that the provided nanosecond count be less than 1 billion (the number of nanoseconds in a second).Tracking issue: #125748