Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Don't recompute tail in lower_stmts #125790

Merged
merged 1 commit into from
May 31, 2024
Merged

Don't recompute tail in lower_stmts #125790

merged 1 commit into from
May 31, 2024

Conversation

WaffleLapkin
Copy link
Member

Does not really matter, but this is slightly nicer.

@bors rollup

@rustbot
Copy link
Collaborator

rustbot commented May 30, 2024

r? @lcnr

rustbot has assigned @lcnr.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. labels May 30, 2024
@lcnr
Copy link
Contributor

lcnr commented May 30, 2024

@bors r+ rollup

@bors
Copy link
Contributor

bors commented May 30, 2024

📌 Commit 86afea9 has been approved by lcnr

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels May 30, 2024
@matthiaskrgr matthiaskrgr mentioned this pull request May 31, 2024
Merged
bors added a commit to rust-lang-ci/rust that referenced this pull request May 31, 2024
@bors
Auto merge of rust-lang#125797 - matthiaskrgr:rollup-v2jmg7i, r=matth…
bf8fff7 
…iaskrgr

Rollup of 4 pull requests

Successful merges:

 - rust-lang#125635 (Rename HIR `TypeBinding` to `AssocItemConstraint` and related cleanup)
 - rust-lang#125774 (Avoid unwrap diag.code directly in note_and_explain_type_err)
 - rust-lang#125786 (Fold item bounds before proving them in `check_type_bounds` in new solver)
 - rust-lang#125790 (Don't recompute `tail` in `lower_stmts`)

r? `@ghost`
`@rustbot` modify labels: rollup
@bors bors merged commit c11e057 into rust-lang:master May 31, 2024
6 checks passed
rust-timer added a commit to rust-lang-ci/rust that referenced this pull request May 31, 2024
@rust-timer
Unrolled build for rust-lang#125790
ea71b8f 
Rollup merge of rust-lang#125790 - WaffleLapkin:no-tail-recomputation-in-lower-stmts, r=lcnr

Don't recompute `tail` in `lower_stmts`

Does not really matter, but this is slightly nicer.

`@bors` rollup
@rustbot rustbot added this to the 1.80.0 milestone May 31, 2024
@WaffleLapkin WaffleLapkin deleted the no-tail-recomputation-in-lower-stmts branch June 5, 2024 13:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@lcnr lcnr

Labels
S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.
Projects
None yet
Milestone
1.80.0
Development

Successfully merging this pull request may close these issues.
4 participants
@WaffleLapkin @rustbot @lcnr @bors