Add TODO comment to unsafe env modification #126019
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rustbot
added
S-waiting-on-review
|
Sorry, I can't take this review currently. |
RalfJung
reviewed
Jun 5, 2024
fee1-dead
reviewed
Jun 5, 2024
5 tasks
|
☔ The latest upstream changes (presumably #126056) made this pull request unmergeable. Please resolve the merge conflicts. |
tbu-
force-pushed
the
pr_unsafe_env_fixme
branch
2 times, most recently
from
8f82878
to
12a98c2
Compare
This comment has been minimized.
This comment has been minimized.
tbu-
force-pushed
the
pr_unsafe_env_fixme
branch
from
12a98c2
to
21387e4
Compare
rustbot
added
A-testsuite
tbu-
force-pushed
the
pr_unsafe_env_fixme
branch
from
21387e4
to
6ae6416
Compare
|
@fee1-dead Changed it to |
tbu-
changed the title
rustbot
added
S-waiting-on-author
Addresses rust-lang#124636 (comment). I think that the diff display regresses a little, because it's no longer showing the `+` to show where the `unsafe {}` is added. I think it's still fine.
tbu-
force-pushed
the
pr_unsafe_env_fixme
branch
from
6ae6416
to
4f5fb31
Compare
|
@rustbot ready |
rustbot
added
S-waiting-on-review
|
Thanks! |
bors
added
S-waiting-on-bors
bors
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Jun 12, 2024
…mpiler-errors Rollup of 8 pull requests Successful merges: - rust-lang#125869 (Add `target_env = "p1"` to the `wasm32-wasip1` target) - rust-lang#126019 (Add TODO comment to unsafe env modification) - rust-lang#126036 (Migrate `run-make/short-ice` to `rmake`) - rust-lang#126276 (Detect pub structs never constructed even though they impl pub trait with assoc constants) - rust-lang#126282 (Ensure self-contained linker is only enabled on dev/nightly ) - rust-lang#126317 (Avoid a bunch of booleans in favor of Result<(), ErrorGuaranteed> as that more robustly proves that an error has been emitted) - rust-lang#126324 (Adjust LoongArch64 data layouts for LLVM update) - rust-lang#126340 (Fix outdated predacates_of.rs comments) r? `@ghost` `@rustbot` modify labels: rollup
rust-timer
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Jun 12, 2024
Rollup merge of rust-lang#126019 - tbu-:pr_unsafe_env_fixme, r=fee1-dead Add TODO comment to unsafe env modification Addresses rust-lang#124636 (comment). I think that the diff display regresses a little, because it's no longer showing the `+` to show where the `unsafe {}` is added. I think it's still fine. Tracking: - rust-lang#124866 r? `@RalfJung`
This was referenced Jun 21, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addresses #124636 (comment).
I think that the diff display regresses a little, because it's no longer showing the
+to show where theunsafe {}is added. I think it's still fine.Tracking:
std::env::{set_var, remove_var}unsafe #124866r? @RalfJung