CI: fix publishing of toolstate history #126033
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rustbot
added
A-testsuite
|
Thanks! I believe PR-triggered jobs do not have access to the secret context, so even if the secret was set in the rust-lang/rust repository, it would be empty in the PR job. Personally I would prefer to see secrets only set in very constrained jobs to reduce the chance of being compromised or exfiltrated in some way. However, previously it was on the @bors r+ rollup |
bors
added
S-waiting-on-bors
Indeed, it is empty on PR jobs. |
bors
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Jun 6, 2024
…kingjubilee Rollup of 12 pull requests Successful merges: - rust-lang#125220 (Repair several `riscv64gc-unknown-linux-gnu` codegen tests) - rust-lang#126033 (CI: fix publishing of toolstate history) - rust-lang#126034 (Clarify our tier 1 Windows Server support) - rust-lang#126035 (Some minor query system cleanups) - rust-lang#126051 (Clarify an `x fmt` error.) - rust-lang#126059 (Raise `DEFAULT_MIN_STACK_SIZE` to at least 64KiB) - rust-lang#126064 (Migrate `run-make/manual-crate-name` to `rmake.rs`) - rust-lang#126072 (compiletest: Allow multiple `//@ run-flags:` headers) - rust-lang#126073 (Port `tests/run-make-fulldeps/obtain-borrowck` to ui-fulldeps) - rust-lang#126081 (Do not use relative paths to Rust source root in run-make tests) - rust-lang#126086 (use windows compatible executable name for libcxx-version) - rust-lang#126096 ([RFC-2011] Allow `core_intrinsics` when activated) r? `@ghost` `@rustbot` modify labels: rollup
rust-timer
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Jun 7, 2024
Rollup merge of rust-lang#126033 - Kobzol:fix-toolstate-history, r=ehuss CI: fix publishing of toolstate history Hopefully fixes the upload of toolstate history that I broke in rust-lang#125145. The problem is that the toolstate environment variables need to be available not just when updating `latest.json` through the Bash/Python script, but also in the main CI workflow, where `history` is updated in bootstrap (the toolstate logic is distributed in two places :/ ). The only tricky thing is how to pass the token secret to the CI job, as I need to enable it only for privileged (`auto`/`try`) builds. I assume that the secret is filled only on `rust-lang-ci`, not on `rust-lang`, so I chose the easiest way of just configuring the environment variable globally. We'll see if that works on PR CI. r? `@ehuss`
|
Looks like it works now (rust-lang-nursery/rust-toolstate@6aedc60). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hopefully fixes the upload of toolstate history that I broke in #125145. The problem is that the toolstate environment variables need to be available not just when updating
latest.jsonthrough the Bash/Python script, but also in the main CI workflow, wherehistoryis updated in bootstrap (the toolstate logic is distributed in two places :/ ).The only tricky thing is how to pass the token secret to the CI job, as I need to enable it only for privileged (
auto/try) builds. I assume that the secret is filled only onrust-lang-ci, not onrust-lang, so I chose the easiest way of just configuring the environment variable globally. We'll see if that works on PR CI.r? @ehuss