-
Notifications
You must be signed in to change notification settings - Fork 13.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
run-make: add some basic docs about the test suite's setup #126087
Conversation
d49c399
to
aa85726
Compare
aa85726
to
d70379e
Compare
@rustbot review |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, at least now there is some basic documentation about this, for the uninitiated. I left two nits, but otherwise LGTM. This should wait for #126097, ofc.
d70379e
to
940fa4a
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Feel free to r=me once #126097 gets merged :)
#126097 has been merged. |
940fa4a
to
e7409d2
Compare
@bors rollup |
☀️ Test successful - checks-actions |
Finished benchmarking commit (13423be): comparison URL. Overall result: no relevant changes - no action needed@rustbot label: -perf-regression Instruction countThis benchmark run did not return any relevant results for this metric. Max RSS (memory usage)This benchmark run did not return any relevant results for this metric. CyclesResults (primary -0.4%, secondary 2.3%)This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.
Binary sizeThis benchmark run did not return any relevant results for this metric. Bootstrap: missing data |
r? @Kobzol